docs(supervise): drop stale PiSeam reference from the bridge seam comment - #744
Conversation
…ment The bespoke pi executor and its PiSeam type were removed in fee8898; the activityWindow doc comment still cited PiSeam as the source of the default. The default stands on its own. Regenerates docs/api to match.
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved drewstone PR — 5d585d10
This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: drewstone_author · 2026-08-06T08:44:34Z
tangletools
left a comment
There was a problem hiding this comment.
🟢 Value Audit — sound
| Verdict | sound |
| Concerns | 0 (none) |
| Heuristic | 0.0s |
| Duplication | 0.0s |
| Interrogation | 53.4s (2 bridge agents) |
| Total | 53.4s |
💰 Value — sound
Drops a stale doc-comment reference to the deleted PiSeam type and regenerates the matching typedoc output; minimal, correct, in-grain cleanup.
- What it does: Removes '(matches
PiSeam)' from the BridgeSeam.activityWindow doc comment in src/runtime/supervise/runtime.ts:337 and regenerates the typedoc mirror at docs/api/runtime.md:11896 so neither cites a type that no longer exists (deleted in fee8898, 0.119.0). - Goals it achieves: Eliminate a dangling cross-reference in public/inline docs so readers aren't sent hunting for a type that was removed; keep generated API docs in sync with source. A repo-wide grep (piExecutor|PI_RUNTIME|PiSeam|piSeamKey|PiExecutorOutput|PiMcp|PI_MCP|pi-executor|pi-mcp) confirms this was the only live orphan outside CHANGELOG.
- Assessment: Good change on its merits. A doc comment pointing at a deleted type is a real (if minor) defect — it misleads anyone reading the seam contract. The fix is the smallest accurate edit: delete the citation, keep the standalone default value, regenerate the checked-in typedoc. No behavior change, no API change, in the grain of a codebase that CI-checks docs/api via docs:check. Scope is exactly proport
- Better / existing approach: none — this is the right approach. Verified: git show fee8898 confirms PiSeam's deletion and that the pi-executor removal was a deliberate dedup (cli-bridge already routes pi generically); grep across src/tests/docs/bench/examples/README returns zero remaining orphans; the only alternative (leave the dangling reference) is strictly worse. The PR body's 'Changed files (1)' is inaccurate — the comm
- Model: opencode/zai-coding-plan/glm-5.2
- Bridge attempts: 2
- Bridge warning: opencode/kimi-for-coding/k2p7: opencode: opencode error
🎯 Usefulness — sound
Correct docs-hygiene fix removing a stale cross-reference to the deleted PiSeam type from a doc comment on a live, heavily-used interface; default of 12 verified against code.
- Integration: The edited surface is live, not dead. BridgeSeam is exported from src/runtime/index.ts:713 and is a member of the backend discriminated union at src/runtime/supervise/runtime.ts:3498. Its activityWindow field is read at runtime.ts:1621 (seam.activityWindow ?? 12) feeding createActivityLog, mirrored in sandbox-session.ts:104, and exercised by 5 test sites in environment-provider.test.ts. The commen
- Fit with existing patterns: No pattern conflict — this is a one-line correction to an existing doc comment, plus the typedoc regen of docs/api/runtime.md that CI's docs:check requires to stay in sync. It removes a dangling reference rather than introducing competing surface. The corrected 'Default 12.' is accurate: the ?? 12 fallback is applied in both runtime.ts:1621 and sandbox-session.ts:104.
- Real-world viability: A comment-only change with no runtime effect, so it holds trivially. The only correctness question is whether the new wording is true, and it is — the default of 12 is enforced in code at both call sites. No behavior, concurrency, or edge-input surface is touched.
- Model: opencode/zai-coding-plan/glm-5.2
- Bridge attempts: 1
No concerns — sound change, no better or existing approach found. ✅
What this audit checks
It judges the change on its merits — not whether it was tasked out in an issue. Unticketed, fast-moving work is fine; the question is whether the change is good and whether a better or existing approach should be used instead.
| Pass | What it asks |
|---|---|
| Heuristic | Vague title? Whitespace-only or cruft-bearing diff? (content signals only) |
| Duplication | Do added function/class names already exist elsewhere in the repo? |
| Value Audit | What does it do? What goal does it achieve? Is it good? Better architecture or already-exists? |
| Usefulness Audit | Does it integrate and fit? Will it hold up in real use and actually get used? |
Findings are concerns, not blocks — the human reviewer decides what to do with them.
✅ No Blockers —
|
| opencode GLM 5.2 | opencode DeepSeek v4 Pro | opencode DeepSeek v4 Flash | aggregate | |
|---|---|---|---|---|
| Readiness | 95 | 95 | 95 | 95 |
| Confidence | 70 | 70 | 70 | 70 |
| Correctness | 95 | 95 | 95 | 95 |
| Security | 95 | 95 | 95 | 95 |
| Testing | 95 | 95 | 95 | 95 |
| Architecture | 95 | 95 | 95 | 95 |
Reviewer score is advisory once the run is complete and the verdict has no blockers.
Full multi-shot audit completed 2/2 planned shots over 2 changed files. Global verifier still owns final merge decision. | Full multi-shot audit completed 2/2 planned shots over 2 changed files. Global verifier still owns final merge decision. | Full multi-shot audit completed 2/2 planned shots over 2 changed files. Global verifier still owns final merge decision.
No findings.
tangletools · 2026-08-06T08:59:33Z · trace
tangletools
left a comment
There was a problem hiding this comment.
✅ Clean — 5d585d10
Full multi-shot audit completed 2/2 planned shots over 2 changed files. Global verifier still owns final merge decision. | Full multi-shot audit completed 2/2 planned shots over 2 changed files. Global verifier still owns final merge decision. | Full multi-shot audit completed 2/2 planned shots over 2 changed files. Global verifier still owns final merge decision.
Full immutable report for this review: trace
Summary comment for this run: full summary
tangletools · 2026-08-06T08:59:33Z · immutable trace
What
Repo-wide audit for leftovers of the pi-executor deletion (0.119.0,
fee88987) found exactly one live orphan: theBridgeSeam.activityWindowdoc comment cited the deletedPiSeamtype as the source of its default (runtime.ts:337), mirrored in the typedoc-generateddocs/api/runtime.md. Fixed the source comment and regenerated docs withpnpm run docs:api(docs/api is CI-checked viadocs:check).Post-fix grep for
piExecutor|PI_RUNTIME|PiSeam|piSeamKey|PiExecutorOutput|PiMcp|PI_MCP|pi-executor|pi-mcpacross src/tests/docs/bench/examples/README: zero hits outside CHANGELOG history.Proof
pnpm typecheckclean (both tsconfigs).