Skip to content

chore(deps): refresh lint toolchain - #47

Merged
xdanger merged 2 commits into
mainfrom
chore/dependency-maintenance-sep-2026
Sep 19, 2026
Merged

xdanger merged 2 commits into
mainfrom
chore/dependency-maintenance-sep-2026

Conversation

@xdanger

@xdanger xdanger commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • update ESLint, globals, lint-staged, Prettier, and typescript-eslint within their current major versions
  • refresh the pnpm lockfile without changing the pnpm requirement
  • narrow the Node engine to ^22.22.1 || >=24, excluding Node.js 23 to match ESLint’s supported runtimes

Verification

  • pnpm install --frozen-lockfile
  • pnpm audit
  • pnpm run lint

- 📦 update compatible lint and formatting dependencies

Dependency maintenance only.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0bba7-5f0b-770b-bb51-b1629435fedc
Co-authored-by: Amp <amp@ampcode.com>
@xdanger xdanger self-assigned this Sep 19, 2026
@github-actions
github-actions Bot requested a lite review from Copilot September 19, 2026 22:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-19T22:05:01.270048Z 49a407e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

未发现阻塞合并的问题,此 PR 看起来可以安全合并。

Summary

此 PR 更新 ESLint、globals、lint-staged、Prettier 和 typescript-eslint,并同步刷新 pnpm 锁文件;后续修改还将 Node.js 支持范围明确为 Node.js 22.22.1–22.x 或 24 及以上。

  • package.json 中的直接开发依赖与 pnpm-lock.yaml importer 保持一致。
  • 锁文件同步记录了更新后的 lint 工具链及其传递依赖。
  • 未发现需要新增评论的正确性、安全性或仓库规则问题。

Reviews (2) · Last reviewed commit: "🔧 chore(node): align supported runtimes"

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Changes are limited to dev-tool dependency bumps and a lockfile refresh, with no functional/runtime code modifications.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Refreshes the linting/tooling dependencies while staying within the existing major-version boundaries, and updates the pnpm lockfile accordingly.

Changes:

  • Bumped ESLint, globals, lint-staged, Prettier, and typescript-eslint to newer versions within their current major versions.
  • Regenerated pnpm-lock.yaml to reflect the updated dependency graph and transitive updates.
File Description
package.json Updates devDependency versions for the lint/format toolchain.
pnpm-lock.yaml Refreshes the lockfile to match the updated toolchain versions and their transitive deps.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
- 🔧 exclude unsupported Node.js 23 releases

Dependency compatibility only.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0bba7-5f0b-770b-bb51-b1629435fedc
Co-authored-by: Amp <amp@ampcode.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The PR description claims Node requirements were unchanged, but engines.node was tightened, so the stated scope needs to be corrected (or the change reverted if unintended).

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
Resolved since last review (1)
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Changes are confined to dependency/version metadata and the Node engine constraint is consistent with the updated lint toolchain’s declared runtime support.

Review effort: Lite
Findings: None

Resolved since last review (1)
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

@xdanger
xdanger merged commit 1e4cf8e into main Sep 19, 2026
6 of 8 checks passed
@xdanger
xdanger deleted the chore/dependency-maintenance-sep-2026 branch September 19, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants