Conversation
Finefinee
force-pushed
the
fix/account-scoped-session-recovery/#224
branch
from
September 17, 2026 11:50
8fa31a4 to
93febe6
Compare
Finefinee
changed the base branch from
main
to
feat/android-youtube-preferences/#223
September 17, 2026 11:50
Finefinee
force-pushed
the
fix/account-scoped-session-recovery/#224
branch
from
September 17, 2026 11:53
93febe6 to
3e5c9d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR을 만든 이유
403이후 원래 계정의 owner token을 잃고409 session_already_exists에서 복구하지 못할 수 있습니다.변경 내용
sub별로 분리했습니다.204,404,403에서 제거합니다.POST /sessions가409 session_already_exists로 거부된 경우에만 legacy owner token으로 삭제를 시도하고,204·404일 때 기록을 제거한 뒤 세션 생성을 재시도합니다.403이면 owner token을 보존합니다. 다른 계정이POST /sessions에 성공하면 legacy 기록을 읽거나 삭제하지 않습니다.sub요구를 통과하도록 유효한 테스트 JWT를 사용하게 수정했습니다.403보존 및 세션 생성 재시도에 대한 회귀 테스트를 추가했습니다.확인 방법
./gradlew :app:compileDebugAndroidTestKotlin :app:testDebugUnitTestANDROID_SERIAL=emulator-5554 ./gradlew :app:connectedDebugAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=com.framework.innolive.feature.live.SessionRecoveryApiTest,com.framework.innolive.feature.live.BroadcastApiFlowTest,com.framework.innolive.feature.live.BroadcastPreparationTestPOST 201, 원래 계정 복구는POST 409 → DELETE 204 → POST 201, 계정 불일치는POST 409 → DELETE 403순서를 확인계약 영향
/sessions/{id}삭제 API와X-Session-Owner-Token헤더를 유지합니다.Closes #224