resolve . and .. server-side in the NFS export - #69
Merged
Conversation
NfsBacking::lookup routed every name through valid_component, which
rejects "." and ".." outright, so LOOKUP answered NFSERR_NOENT for both.
SVR4-derived clients (IRIX's is one) short-circuit "." locally but send
".." over the wire on every DNLC miss — lookuppn only intercepts it at a
mount root and at the process root — so chdir(".."), ../x and getcwd-style
walks all failed on the share. readdir omitted both entries too, despite
the comment claiming the wire layer synthesized them; neither encoder did.
No tree structure is needed: id_to_path already holds the full relative
path for every fileid, so parent_id pops one component and interns it.
pop() returning false means the export root, where ".." resolves to itself
and cannot walk out. valid_component is unchanged, so CREATE/MKDIR/REMOVE/
RENAME still refuse both names. Both encoders name-sort before paging and
"." < ".." < everything else, so the READDIR cookie stays stable.
Fixes techomancer#68
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NfsBacking::lookup routed every name through valid_component, which rejects "." and ".." outright, so LOOKUP answered NFSERR_NOENT for both. SVR4-derived clients (IRIX's is one) short-circuit "." locally but send ".." over the wire on every DNLC miss — lookuppn only intercepts it at a mount root and at the process root — so chdir(".."), ../x and getcwd-style walks all failed on the share. readdir omitted both entries too, despite the comment claiming the wire layer synthesized them; neither encoder did.
No tree structure is needed: id_to_path already holds the full relative path for every fileid, so parent_id pops one component and interns it. pop() returning false means the export root, where ".." resolves to itself and cannot walk out. valid_component is unchanged, so CREATE/MKDIR/REMOVE/ RENAME still refuse both names. Both encoders name-sort before paging and "." < ".." < everything else, so the READDIR cookie stays stable.
Fixes #68