Repository navigation
Remove stray sdmx_ml import from tpdb tests - #94
Merged
Merged
Conversation
The tpdb tests never used sdmx_ml models. During invoke all, the sdmx_ml build deletes and regenerates sdmx_ml/models in parallel, so tpdb test collection failed with ModuleNotFoundError when it ran mid-rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tpdb/test_bindings.pyhad a leftoverfrom sdmx_ml.models import *from when the suite was added. The test uses nothing from it.invoke allbuilds every suite in parallel, and each build starts withrm -rf {suite}/models. When tpdb test collection ran while sdmx_ml was regenerating, the import failed withModuleNotFoundError: No module named 'sdmx_ml.models'.Testing
sdmx_ml/modelsmoved away,pytest tpdb/gives 254 passed.invoke all: 20 passed, 0 failed, no output changes.