Escalated an aborted turn to SIGKILL. - #5
Open
moedash wants to merge 1 commit into
Open
Conversation
Aborting a turn sent the child a polite signal and trusted it to exit. Codex holds a writer lock on the thread for as long as it lives, so a child that ignores the signal blocks every later resume of that thread with "already has an active writer". Verified against a child that ignores SIGTERM on purpose.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Aborting a turn through the SDK escalates to
SIGKILLif the child has not exited within a grace period.Why?
The abort sent the child a polite signal and trusted it to exit. Codex holds a writer lock on the thread for as long as it lives, so a child that ignores the signal blocks every later resume of that thread with
already has an active writer. The caller has no way to escalate, because the SDK owns the spawn.How did you test it?
Against a child that ignores
SIGTERMon purpose: the abort now kills it and the caller gets its error, where before both the child and the lock survived.