fix: improve Markdown content negotiation - #5178
Open
lennessyy wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview linksThis PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Markdown content negotiation headers and a recoverable Markdown 404 response.
Changes:
- Adds
Varyheaders to negotiated responses. - Rewrites missing Markdown routes to a dedicated 404 endpoint.
- Returns Markdown recovery links for missing pages.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
vercel.json |
Routes unmatched Markdown requests to the 404 endpoint. |
middleware.js |
Adds negotiation-aware Vary headers. |
api/markdown-not-found.js |
Implements the Markdown 404 response. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vary: Accept, Accept-Encodingto both negotiated Markdown and HTML responsesValidation
yarn buildnode tests/run-all.mjsvercel build --prod --yes