Repository navigation
Read Node, pnpm, and Go versions from the synced UI - #343
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sync from UI fails at
pnpm install:temporalio/ui#4058 raised
engines.nodeto>=22.23.4. Thesetup-nodeaction here asks fornode-version: 22, and the runner cache gives 22.23.3. The commit sync and the v2.57.0 release sync both fail.Change
The actions read the versions from files, not from pins in this repo:
setup-node: Node comes fromui-release/.node-version. pnpm comes frompackageManagerinui-release/package.json.ui-release/is the checkout of temporalio/ui at the ref that is built.setup-go: Go comes fromgo.mod. The sync copiesgo.modfromui/server.When temporalio/ui changes these versions, this repo does not need a change.
pnpm changes from 10.34.7 to 10.10.0. temporalio/ui CI uses the same version, and temporalio/ui owns the lockfile.
After merge
Send the v2.57.0 release dispatch again: