Repository navigation
Use engines.node as the single Node version source - #4069
Merged
Merged
Conversation
Cap engines.node at the 22 major (^22.23.4) and have CI read it from package.json. Remove .node-version and the nodejs line in .tool-versions, which duplicated it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
laurakwhit
approved these changes
Oct 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
engines.node:>=22.23.4→^22.23.4.package.json(node-version-file: package.json) insetup-nodeand in the weekly dependency security review, instead of a hardcoded'22.23.4'..node-versionand thenodejsline in.tool-versions. Thepnpmandgolanglines stay.Why
Node was pinned in five places:
.node-version,.tool-versions,engines.node, and two workflow files. CI read none of the files, so they could drift without anything failing. They have drifted before (.tool-versionsat 22.14.0 while.node-versionwas at 22.18.0).With one source:
package.json, use the same Node.^cap keeps hosts that pick Node fromengines(for example, Vercel) on 22, the same major as CI and the Docker images. With>=, they pick the newest major.engine-strict=truestill rejects any Node below 22.23.4.actions/setup-noderesolves^22.23.4to the newest 22.x, so CI picks up 22 patch releases on its own.Merge order
temporalio/ui-server#344 reads Node from this file. Merge it first, then this PR, so the ui-server sync never looks for the deleted
.node-version.Local setup
If your version manager read
.node-versionor.tool-versions, install any Node 22 ≥ 22.23.4. fnm (--resolve-engines) and mise can readengines.node.