Skip to content

Updated the comparison to always ensure string-to-string matching #1015 - #1018

Merged
SteveMcGrath merged 1 commit into
mainfrom
fix/scrublog
Aug 26, 2026
Merged

SteveMcGrath merged 1 commit into
mainfrom
fix/scrublog

Conversation

@SteveMcGrath

Copy link
Copy Markdown
Contributor

Description

Corrects the errant behaviour of comparing a potentially non-string value to a string. This update will effectively
coerce the value to a string first, then compare it against the sanitized version.

Fixes #1015

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual testing confirmed the corrected behavior.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath
SteveMcGrath requested a review from a team as a code owner August 24, 2026 20:57

@amaruf-tenb amaruf-tenb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SteveMcGrath
SteveMcGrath merged commit 9f34f9a into main Aug 26, 2026
10 checks passed
@SteveMcGrath
SteveMcGrath deleted the fix/scrublog branch August 26, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scrub() logs a false-positive "unsafe chars" warning for any non-str input (e.g. int chunk IDs)

2 participants