Repository navigation
Solve on views in colstimespivotinv and pivotinvtimesrows - #77
Open
NepomukRitz wants to merge 1 commit into
Open
NepomukRitz wants to merge 1 commit into
NepomukRitz wants to merge 1 commit into
Conversation
colstimespivotinv and pivotinvtimesrows copied the slices of L and U they pass to the triangular solve. Views reach the same triangular solve (BLAS trsm, LAPACK trtrs) on the same values, and only the copy is gone. Outputs unchanged bit for bit on a harness of seeded ACI products, and both solves give bit-identical results on views and on copies (Float64 and ComplexF64, several sizes, 1 and 8 BLAS threads). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
colstimespivotinvandpivotinvtimesrowsslicedLandUinto copies before the triangular solve. Views reach the same solve (BLAStrsmfor/, LAPACKtrtrsfor\) on the same values, and only the copy is gone.Outputs are bit-identical on seeded AlternatingCrossInterpolation products, and both solves agree bit for bit on views and copies (Float64 and ComplexF64, several sizes, 1 and 8 BLAS threads, bundled OpenBLAS). The test suite passes.
Found by an allocation profile of ACI products in ReFrequenTT.
🤖 Generated with Claude Code