Repository navigation
svd: run test_josef in the nightly LAPACK validation, with a stated ignore reason - #131
Merged
Merged
Conversation
…g ignored without a reason `linalg::svd::bidiag_svd::tests::test_josef` came from upstream with a bare `#[ignore]`. Run with `--include-ignored` it passes: the n = 8660 f32 divide-and-conquer SVD of `test_data/svd/svd_josef.txt` reconstructs within its tolerance (67 s in the test profile, 66 s in release, peak 2.3 GB). The data is intact (8660 diagonal and 8660 subdiagonal entries); it is the only file in `test_data/svd/` above the test's n > 1024 cut. At a minute it is too slow for every test run, so the ignore now states why, and the nightly LAPACK validation runs it in a family of its own, `svd_large` (300 s limit), selected by exact name. The svd family could not take it: it already uses 53 of its 120 s on the hosted runner. The family limits now sum to 25 minutes, so the step and job timeouts grow by five minutes (49 and 55). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linalg::svd::bidiag_svd::tests::test_josefcame from upstream with a bare#[ignore](sarah quiñones added the test and its data ine2d0a6f, 2024-10-18). The maintainer asked to run it and act on the result.Result: it passes. With
--include-ignored, the n = 8660 f32 divide-and-conquer SVD oftest_data/svd/svd_josef.txt(full U and V) reconstructs within the test's tolerance. So this is not a correctness defect: no issue is filed, and there is nothing to add toupstream-reports/.cargo test --releasecargo test(test profile, opt-level 3)/usr/bin/time -vData:
faer/test_data/svd/is present and intact.svd_josef.txthas 8660 diagonal and 8660 subdiagonal entries. It is the only file there above the test'sn > 1024cut; the other six files are skipped by this test.Change
At about a minute, the test is too slow to run with every test, so it stays ignored, now with a stated reason, and the nightly LAPACK validation runs it:
#[ignore = "large (n = 8660): runs in the nightly LAPACK validation"], plus a comment pointing to the runner.scripts/run-lapack-validation.py: a new familysvd_large(300 s limit) selected by exact name (LARGE_SVD). The existingsvdfamily could not take it: on the hosted runner it already uses 53 of its 120 s (last nightly run).scripts/test-lapack-validation.py: classification tests for the new family (test_josefgoes tosvd_large, otherbidiag_svdtests are not selected), and the last family is nowsvd_large.docs/lapack-validation.md: the timeout figures and the new family.Verification
python3 scripts/test-lapack-validation.py: 8 tests OK. Both scripts compile with Python 3.10.selected_testsgivessvd_large = [test_josef]andsvd88 tests. The limits sum to 1500 s.--exact … --include-ignored --nocapture --test-threads=1) passes locally in 71 s.🤖 Generated with Claude Code