Repository navigation
rules: explicitly prohibit handwritten contraction kernels - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add one short paragraph next to the existing owning-backend/linalg rule in
rules/rust/performance.md:einsum_tensors,tcontract,tlinalg, or the owning backend provider.// contraction-kernel-ok: <reason>immediately above a genuinely unavoidable loop and disclose the exception in the PR description.The identical paragraph is added near the top of tenferro-rs's
AGENTS.md, alongside a mechanically enforced CI guard, in tensor4all/tenferro-rs#2347. This PR only adds the paragraph: no restructuring, dependencies or other rule changes.Background: tensor4all/tensor4all-rs#1064's
SimpleTensorTrain::full_tensorshipped a scalar axpy nest despite the existing owning-abstraction rule. The enforcement PR is in tenferro-rs as requested; this shared paragraph documents the same exception convention.Validation
validate-rulesworkflow's Python standard-library relative-link check: all 15rules/index.mdlinks resolve.AGENTS.md.git diff --checkpassed; onlyrules/rust/performance.mdchanged.validate-rulesCI passed on head4d1a34eee87b18f8532dea3d8ba47daeb6d70587.Do not merge or enable auto-merge.