fix: disambiguate duplicate Verso labels in MeasureTheory Section 1.1.3 - #659
Open
Chessing234 wants to merge 1 commit into
Open
fix: disambiguate duplicate Verso labels in MeasureTheory Section 1.1.3#659Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Twenty-one docstrings across seven groups shared a label: Definition 1.1.15, Exercise 1.1.20, Exercise 1.1.21 (a) and (c), Definition 1.1.6, Exercise 1.1.22 and Exercise 1.1.25. Each label now names the case it covers, taken from the `--` comment already sitting on the declaration underneath it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven groups of sibling declarations in
MeasureTheory/Section_1_1_3.leanshare a docstring:Definition 1.1.6 (Darboux integral)Exercise 1.1.21 (a) (Linearity of the piecewise constant integral)Exercise 1.1.25 (Area interpretation of Riemann integral)Definition 1.1.15 (Riemann integrability)Exercise 1.1.20 (Piecewise constant functions)Exercise 1.1.21 (c) (Piecewise constant integral of indicator functions)Exercise 1.1.22Same convention as #624: keep the statement number, name the case in the parenthetical. The case names are not invented — each is taken from the
--comment already sitting between the docstring and the declaration (e.g. "The lower Darboux integral: …" →(Darboux integral, lower)).The two long labels were shortened to
(Linearity, …)and(Area interpretation, …)so the lines stay inside the 100-character limit; the exercise number still identifies the statement.Checked: no duplicate one-line docstrings remain in the file, all edited lines within 100 characters.
lake build Analysis.MeasureTheory.Section_1_1_3succeeds locally —✔ [3281/3281] Built (19s),Build completed successfully.Chosen to avoid the files our other open PRs touch (#647 Section_1_3_2, #648 Section_1_1_2, #649/#650 Section_1_2_0, #646 Section_1_4_2), so this does not collide with any of them.