Repository navigation
chore: move development dependencies to the Gemfile - #135
Merged
Merged
Conversation
Development dependencies belong in the Gemfile, not the gemspec. Declaring them in the gemspec ships them as real metadata to every consumer and duplicates constraints already expressed in the Gemfile. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
minitest,mochaandyardinto the Gemfile's:testgroup (rakeis already declared there), and drops the:debuggroup —pry,pry-byebugandpry-stack_explorerare referenced nowhere in the repo.The Gemfile already says
gemspec development_group: :test, so all four were resolving into:testanyway; the installed bundle is unchanged apart from the pry gems.yardis deliberately kept in:testrather than moved to a separate:docsgroup. The Rakefile does an unguardedrequire "yard"at the top level, so ifyardwere in a group anyone could exclude,BUNDLE_WITHOUT=docswould make every rake task — includingrake unit— fail to load. Guarding that require the way thecookstyleblock just above it already is would be a good follow-up.