Repository navigation
Prefer native SwiftUI components and audit presentation lifecycle - #47
Conversation
|
Final review approval supplied by the repository owner in the active Codex task, followed by explicit authorization to merge and release 0.0.37. Approval source: user-supplied copy of the ChatGPT review. Relay response collection remains tracked in https://github.com/thatfactory/reasoning-relay/issues/95; this record does not claim a Relay-authenticated result or receipt. The supplied review independently inspected the complete seven-file diff, issue #46, repository contract, and surrounding files. It confirmed the native-component policy, presentation ownership and cancellation rules, mandatory audit gate, 29 mutation cases, and consistent 0.0.37 metadata. It also verified the exact-head CI result: 38 tests passed and 20 guidelines validated. Pre-merge verification confirmed the same base/head pair, green exact-head CI, a mergeable PR, a clean working tree, and no GitHub review findings or unresolved threads. No source changes were made after approval. |
SwiftUI implementations can currently pass the completion audit after replacing a suitable system presentation with a sheet-shaped overlay. Make native SwiftUI and platform components the explicit default, while accepting branded content inside components whose lifecycle remains system-owned.
The SwiftUI guide now requires a verified capability gap, explicit owner approval, and a durable consumer exception before implementing a custom equivalent. It defines independent child dismissal, parent draft retention, active nested presenters, idempotent cancellation, stale-result protection, dismissal-completion cleanup, and runtime interaction evidence. The audit links to this policy and blocks unsupported replacements or missing relevant evidence, including gestures that static screenshots cannot prove.
Prepare 0.0.37 in VERSION, CHANGELOG.md, and both README subtree commands. Tag and release publication follow the reviewed merge workflow.
Acceptance covers simulated sheets, native nested sheets with branded content, approved custom equivalents, alerts/confirmation dialogs and other native components, and missing runtime evidence. The validator protects these requirements; mutation regressions exercise 17 policy changes and 12 audit-gate changes. These are policy-document validation tests; consumer runtime behavior is verified when the policy is applied to app changes.
Validation:
Tests/run_tests.swift— all 38 native Swift tests passed.Scripts/validate_guidelines.swift— 20 guidelines validated for 0.0.37.Scripts/swift_format.sh format-and-lint Scripts Tests .agents/skills/agent-guidelines-audit/scriptsandlint-strict— passed.git diff --check— passed.Closes #46.