Skip to content

Prefer native SwiftUI components and audit presentation lifecycle - #47

Merged
backslash-f merged 1 commit into
mainfrom
codex/46-native-swiftui-components
Oct 14, 2026
Merged

backslash-f merged 1 commit into
mainfrom
codex/46-native-swiftui-components

Conversation

@backslash-f

@backslash-f backslash-f commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

SwiftUI implementations can currently pass the completion audit after replacing a suitable system presentation with a sheet-shaped overlay. Make native SwiftUI and platform components the explicit default, while accepting branded content inside components whose lifecycle remains system-owned.

The SwiftUI guide now requires a verified capability gap, explicit owner approval, and a durable consumer exception before implementing a custom equivalent. It defines independent child dismissal, parent draft retention, active nested presenters, idempotent cancellation, stale-result protection, dismissal-completion cleanup, and runtime interaction evidence. The audit links to this policy and blocks unsupported replacements or missing relevant evidence, including gestures that static screenshots cannot prove.

Prepare 0.0.37 in VERSION, CHANGELOG.md, and both README subtree commands. Tag and release publication follow the reviewed merge workflow.

Acceptance covers simulated sheets, native nested sheets with branded content, approved custom equivalents, alerts/confirmation dialogs and other native components, and missing runtime evidence. The validator protects these requirements; mutation regressions exercise 17 policy changes and 12 audit-gate changes. These are policy-document validation tests; consumer runtime behavior is verified when the policy is applied to app changes.

Validation:

  • Tests/run_tests.swift — all 38 native Swift tests passed.
  • Scripts/validate_guidelines.swift — 20 guidelines validated for 0.0.37.
  • Scripts/swift_format.sh format-and-lint Scripts Tests .agents/skills/agent-guidelines-audit/scripts and lint-strict — passed.
  • Markdown wrapping checker over all four changed Markdown files — passed.
  • git diff --check — passed.
  • GitHub CI — Validate guidelines passed for head 35c6418.
  • Completion audit — passed; root ignore patterns match the shared template, and no consumer files or private content were introduced.

Closes #46.

@backslash-f

Copy link
Copy Markdown
Contributor Author

Final review approval supplied by the repository owner in the active Codex task, followed by explicit authorization to merge and release 0.0.37.

Approval source: user-supplied copy of the ChatGPT review. Relay response collection remains tracked in https://github.com/thatfactory/reasoning-relay/issues/95; this record does not claim a Relay-authenticated result or receipt.

Verdict: APPROVED
Reviewed-PR: https://github.com/thatfactory/agent-guidelines/pull/47
Reviewed-Base: aa5f04be779ea5ca31bf4a3949390a46c10ac322
Reviewed-Head: 35c6418bec8df6a4b6882aca4d756c7fb818bd2f
Blocking-Findings:
- None.
Non-Blocking-Findings:
- None.

The supplied review independently inspected the complete seven-file diff, issue #46, repository contract, and surrounding files. It confirmed the native-component policy, presentation ownership and cancellation rules, mandatory audit gate, 29 mutation cases, and consistent 0.0.37 metadata. It also verified the exact-head CI result: 38 tests passed and 20 guidelines validated.

Pre-merge verification confirmed the same base/head pair, green exact-head CI, a mergeable PR, a clean working tree, and no GitHub review findings or unresolved threads. No source changes were made after approval.

@backslash-f
backslash-f marked this pull request as ready for review October 14, 2026 20:34
@backslash-f
backslash-f merged commit dc26d7c into main Oct 14, 2026
1 check passed
@backslash-f
backslash-f deleted the codex/46-native-swiftui-components branch October 14, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefer native SwiftUI components and audit presentation lifecycle decisions

1 participant