Skip to content

Preserve Apple control placement and add guidance update workflow - #50

Merged
backslash-f merged 2 commits into
mainfrom
codex/apple-control-placement
Oct 20, 2026
Merged

backslash-f merged 2 commits into
mainfrom
codex/apple-control-placement

Conversation

@backslash-f

@backslash-f backslash-f commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Standard Close/Back and toolbar controls were being judged by a fixed physical side even when Apple owns their placement. This change makes native platform behavior authoritative, requires semantic intent for toolbar actions, and adds an audit check that distinguishes system-selected placement from app overrides.

The same PR adds $update-agent-guidelines: an explicit invocation plus a shared rule/decision request prepares central guidance and next-version metadata, asks about audit coverage only when unspecified, and proceeds through required review, green CI, authorized merge, and release. Consumer adoption stays separate. Release metadata is aligned at 0.0.40 in VERSION, CHANGELOG, and both README subtree commands.

Acceptance and scope:

  • Canonical policy: Guidelines/Swift/SwiftUI.md#system-control-placement; includes native Back, picker/editor ownership, semantic roles, relevant UIKit/AppKit chrome, and design consistency with native behavior.
  • Audit coverage: explicitly requested and included, with investigation signals, acceptable outcomes, and evidence/blocking criteria.
  • New skill honors explicit audit yes/no, waits for a missing choice, preserves narrower no-merge/no-release instructions, and prevents tag overwrite or duplicate release publication.
  • Documentation and skill only; no app code, dependencies, CI workflow, or consumer subtree changes.

Validation:

  • Scripts/validate_guidelines.swift: passed, 21 guides, version 0.0.40.
  • Tests/run_tests.swift: all 38 native Swift tests passed.
  • Markdown wrapping checker: all five changed Markdown files passed.
  • Skill creator quick_validate.py: passed using an ephemeral validation environment; no repository runtime dependency added.
  • String Catalog inspection gate: no changed catalogs relative to origin/main.
  • git diff --check: passed; .gitignore exactly matches the shared template.
  • Originating consumer's 0.0.39 subtree tree exactly matches the current central tag and has linguist-generated provenance.
  • Official Apple toolbar design and ToolbarItemPlacement documentation checked. No app runtime evidence is claimed for this documentation-only update.

Review: Reasoning Relay exact-commit PR review required before merge; receipt and final CI results will be recorded here.

Reasoning Relay planning/scenario review completed (del_6eaf6600-e4eb-4c5f-b161-babafb7b4a56). Its discovery and authorization gaps were addressed: README documents central checkout/path and independent tagged installation for stale consumers; no release stops at the reviewed PR unless merge without publication is explicit. Audit now distinguishes ordinary content layout, targeted toolbar evidence, and changed presentation lifecycles. Release retries recheck publication state and prefer the existing workflow. Final validator, wrapping, skill validation, and diff checks passed after these wording changes; CI reruns the full test suite for final head d18bb11.

Final Reasoning Relay review: APPROVED, no P0/P1 findings. Reviewer inspected all six changed files directly on GitHub and verified the immutable comparison.

@backslash-f
backslash-f marked this pull request as ready for review October 20, 2026 10:33
@backslash-f
backslash-f merged commit a14a901 into main Oct 20, 2026
1 check passed
@backslash-f
backslash-f deleted the codex/apple-control-placement branch October 20, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant