Repository navigation
Preserve Apple control placement and add guidance update workflow - #50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard Close/Back and toolbar controls were being judged by a fixed physical side even when Apple owns their placement. This change makes native platform behavior authoritative, requires semantic intent for toolbar actions, and adds an audit check that distinguishes system-selected placement from app overrides.
The same PR adds
$update-agent-guidelines: an explicit invocation plus a shared rule/decision request prepares central guidance and next-version metadata, asks about audit coverage only when unspecified, and proceeds through required review, green CI, authorized merge, and release. Consumer adoption stays separate. Release metadata is aligned at 0.0.40 in VERSION, CHANGELOG, and both README subtree commands.Acceptance and scope:
Guidelines/Swift/SwiftUI.md#system-control-placement; includes native Back, picker/editor ownership, semantic roles, relevant UIKit/AppKit chrome, and design consistency with native behavior.Validation:
Scripts/validate_guidelines.swift: passed, 21 guides, version 0.0.40.Tests/run_tests.swift: all 38 native Swift tests passed.quick_validate.py: passed using an ephemeral validation environment; no repository runtime dependency added.git diff --check: passed;.gitignoreexactly matches the shared template.linguist-generatedprovenance.Review: Reasoning Relay exact-commit PR review required before merge; receipt and final CI results will be recorded here.
Reasoning Relay planning/scenario review completed (del_6eaf6600-e4eb-4c5f-b161-babafb7b4a56). Its discovery and authorization gaps were addressed: README documents central checkout/path and independent tagged installation for stale consumers; no release stops at the reviewed PR unless merge without publication is explicit. Audit now distinguishes ordinary content layout, targeted toolbar evidence, and changed presentation lifecycles. Release retries recheck publication state and prefer the existing workflow. Final validator, wrapping, skill validation, and diff checks passed after these wording changes; CI reruns the full test suite for final head d18bb11.
Final Reasoning Relay review: APPROVED, no P0/P1 findings. Reviewer inspected all six changed files directly on GitHub and verified the immutable comparison.