Repository navigation
Align Reduce Motion policy and support claims with Apple criteria - #52
Conversation
|
Reasoning Relay independently inspected the complete eight-file PR diff, relevant surrounding source, and Apple's official Reduced Motion criteria. Verdict: APPROVED, with no blocking or non-blocking findings.
The review confirms per-animation evaluation, system preference/live updates, preserved native adaptations and useful feedback, focused audit scope, platform-specific common-task evidence for declarations, regression coverage, and consistent 0.0.42 metadata. No consumer runtime certification is implied. CI was still running when approval was returned and remains a separate mandatory merge gate. Automatic Codex configuration is unknown with no current-head execution signal observed; no manual Codex review was requested. Local validation and completion-audit evidence are in the PR description. |
The current Reduce Motion rule prevents agents from adapting custom motion unless a task explicitly asks. Replace that restriction with Apple-aligned, per-animation evaluation and make reduced-motion adaptations part of normal implementation.
The canonical policy lives in
Guidelines/Swift/SwiftUI.md#reduce-motionand links Apple's Reduced Motion evaluation criteria, motion HIG, SwiftUI environment API, and Accessibility Nutrition Labels guidance. It preserves native adaptations and useful feedback, addresses identified motion triggers and ongoing motion, and requires preference changes to be respected during use. It does not require blanket animation removal.Audit coverage: explicitly requested. Focused checks cover changed motion and directly affected components with on/off and live preference-change evidence. App-wide support declarations require common-task evidence for the declared platform, including Apple's applicable content/advertising criteria. A component check or guideline adoption alone cannot establish support. The App Store guide links this requirement and preserves separately scoped metadata synchronization.
Prepare release 0.0.42, updating VERSION, dated changelog, and both README subtree commands. No application implementation, consumer migration, App Store Connect write, dependency, or support declaration is part of this PR. Historical changelog entries remain accurate descriptions of older releases.
Validation on macOS:
Scripts/swift_format.sh format-and-lint Scripts/validate_guidelines.swift Tests/run_tests.swift: passed.Scripts/swift_format.sh lint-strict Scripts/validate_guidelines.swift Tests/run_tests.swift: passed.Scripts/validate_guidelines.swift: passed, 21 guidelines at 0.0.42.Tests/run_tests.swift: passed, all 40 native Swift tests; includes policy/audit/link removal mutations and restoration of the obsolete opt-in restriction..agents/skills/agent-guidelines-audit/scripts/check_markdown_wrapping.swift Guidelines/Swift/SwiftUI.md Guidelines/AppStore.md .agents/skills/agent-guidelines-audit/SKILL.md CHANGELOG.md README.md: passed.git diff --check: passed.Completion audit: canonical rule and cross-links are consistent; root ignore template matches exactly; no changed String Catalog, application target, package, or dependency. Originating consumer remains on exact tagged 0.0.40, behind current central 0.0.41; drift was surfaced and adoption remains separate. No private or consumer-specific implementation details are added.
Scenario walkthroughs (policy evaluation, not claimed runtime tests):
Documentation-only policy work needs these walkthroughs, not a simulator run. No consumer app is claimed to support Reduced Motion by this PR. Exact-base/head Reasoning Relay review and green CI are required before merge and release.