Skip to content

fix: stop link preview flicker on hover within nested anchors #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
P-CAmilE wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: stop link preview flicker on hover within nested anchors #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ora/Core/BrowserEngine/Scripts/OraBrowserScripts.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,19 @@ enum OraBrowserScripts {
post('linkHover', url || "");
}

function currentAnchor(node) {
return node && node.closest ? node.closest('a[href]') : null;
}

function onMouseOver(event) {
const anchor = event.target.closest && event.target.closest('a[href]');
const anchor = currentAnchor(event.target);
postHover(anchor ? anchor.href : '');
}
Comment on lines 100 to 103

@greptile-apps greptile-apps Bot Jul 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 onMouseOver still posts redundant bridge messages within the same anchor

onMouseOut now correctly suppresses posts when the anchor stays the same, but onMouseOver unconditionally posts for every child element transition. Moving the cursor across <a href="/foo"><img/><span>text</span></a> produces a mouseover on <img> and then on <span>, both resolving to the same anchor and both issuing a postHover("/foo"). Each call reaches the native side, assigns hoveredLinkURL to an equal string, and triggers objectWillChange — the visual flicker is gone (thanks to the onMouseOut fix), but the redundant IPC can be eliminated by tracking the last-posted anchor reference in JS and early-returning when it hasn't changed.


function onMouseOut(event) {
const related = event.relatedTarget;
if (!related || !event.currentTarget.contains(related)) {
postHover("");
}
const from = currentAnchor(event.target);
const to = currentAnchor(event.relatedTarget);
if (from !== to) postHover(to ? to.href : '');
}

document.addEventListener('mouseover', onMouseOver, true);
Expand Down
1 change: 1 addition & 0 deletions ora/Features/Browser/Views/BrowserWebContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ struct BrowserWebContentView: View {
LinkPreview(text: hovered)
}
}
.animation(.easeOut(duration: 0.12), value: tab.hoveredLinkURL)
} else {
ZStack {
Rectangle().fill(theme.background)
Expand Down
Loading