fix: power-latch false-trigger, RGB LED footprint regression, JST connector clarity - #56
Merged
Merged
Conversation
…nector clarity Power latch: battery-only bring-up showed the board powering on immediately with no button press, because PWR_BTN_SENSE's resistor divider idled at ~VSYS/2, forward-biasing D_OR1's anode directly. Adds a transistor inverter (R_INV_BASE1 / Q_INV1 / R_INV_PU1) so only an actual button press can forward-bias D_OR1; removes the now-unnecessary R_PWR_SENSE1. New parts matched to JLCPCB Basic-library equivalents. PCB layout, diagrams, and power_control_layout docs updated to match. RGB LED: fixes a regression where D_RGB1's Footprint had reverted to the stale large SK6812 PLCC4 part in both the cached lib_symbols default and the instance override, instead of the custom SK6812MINI-E-012 footprint that PCBWay's earlier assembly rejection required. JST battery connector: PCBWay's assembly mounted BT1 vertically instead of horizontal. Confirmed via two independent distributor sources (JLC + LCSC) that the specified MPN (S2B-PH-K(LF)(SN)) is genuinely a right-angle/ horizontal part, so this was an assembly-side error, not a design bug. Made the Value/Description fields explicitly say RIGHT-ANGLE / HORIZONTAL so it's unambiguous in the exported BOM this time. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PWR_BTN_SENSE's resistor divider idled at ~VSYS/2, which was enough to forward-biasD_OR1directly, with or without a press. Fixes it with a small NPN inverter (R_INV_BASE1/Q_INV1/R_INV_PU1) between the button and the diode-OR, and removes the now-unneededR_PWR_SENSE1. New parts matched to JLCPCB Basic-library equivalents (all confirmed via live JLC search). PCB layout, DRC-clean, and thepower_control_layoutdiagrams/docs updated to match.D_RGB1'sFootprinthad reverted to the old/stale large SK6812 PLCC4 part (the one that failed PCBWay's earlier assembly) in both the cachedlib_symbolsdefault and the instance override. Restored to the customSK6812MINI-E-012footprint in both places.BT1vertically instead of horizontal. Verified via two independent distributor sources (JLC + LCSC) that the specified MPN (S2B-PH-K(LF)(SN)) is genuinely right-angle/horizontal — this was an assembly-side error, not a design bug. Made theValue/Descriptionfields explicitly spell out RIGHT-ANGLE / HORIZONTAL so it's unambiguous in the exported BOM for next time.Test plan
kicad-cli sch ercon full schematic hierarchy — 0 errors, 1 pre-existing benign warning (lib_symbol_mismatchon D_RGB1 vs cached lib copy)kicad-cli pcb drc— 0 violationskicad-cli sch export netlist— verified new inverter nets (PWR_BTN_INV_BASE,PWR_BTN_TRIGGER) wired as intendedscripts/jlc_match.py— all 3 new parts + BT1 still match correctly to Basic-library/expected LCSC part numbers🤖 Generated with Claude Code