ST 960 Fix - Spacious theme depreciation warnings - #101
Open
jenisha00 wants to merge 2 commits into
Open
Conversation
added 2 commits
August 4, 2026 14:55
Only add the 'conditional' script data for html5shiv on WP < 6.9, since core dropped IE conditional comment output in 6.9 and the argument is deprecated there.
spacious_hex2rgb() and spacious_darkcolor() assumed the primary color theme mod is always a hex string, but its customizer control allows an rgba() value. Passing that to hexdec() triggered PHP 8.3's "invalid characters" deprecation and silently produced an invalid color. Normalize rgba() input to hex first via a shared spacious_color_to_hex() helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.