Skip to content

Refresh glConfig window and UI viewport sizes when the GL context is set up #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themuffinator merged 1 commit into from
Sep 22, 2026
Merged

Refresh glConfig window and UI viewport sizes when the GL context is set up #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/renderer/OpenGL/gl_ContextSDL3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,17 @@ static void SDL3_WindowParmsFromGlimpParms(const glimpParms_t &src, renderWindow
dst.multiSamples = src.multiSamples;
}

static void SDL3_SyncGLConfigWindowDimensions( const renderModuleWindowInfo_t &windowInfo ) {
if ( windowInfo.pixelWidth > 0 && windowInfo.pixelHeight > 0 ) {
glConfig.vidWidth = windowInfo.pixelWidth;
glConfig.vidHeight = windowInfo.pixelHeight;
}
glConfig.uiViewportX = windowInfo.uiViewportX;
glConfig.uiViewportY = windowInfo.uiViewportY;
glConfig.uiViewportWidth = windowInfo.uiViewportWidth;
glConfig.uiViewportHeight = windowInfo.uiViewportHeight;
}

static bool SDL3_EnsureGLContextCurrent(const char *operation) {
if (!s_glWindow || !s_glContext) {
return false;
Expand Down Expand Up @@ -489,6 +500,7 @@ bool GLimp_Init(glimpParms_t parms) {

s_glWindowServices->RefreshNativeWindowHandles(&windowInfo);
s_glHDC = windowInfo.nativeDisplayHandle;
SDL3_SyncGLConfigWindowDimensions(windowInfo);
SDL3_LoadWGLExtensions();
if (r_swapInterval.IsModified()) {
r_swapInterval.ClearModified();
Expand Down Expand Up @@ -525,6 +537,7 @@ bool GLimp_SetScreenParms(glimpParms_t parms) {
renderModuleWindowInfo_t windowInfo;
windowServices->RefreshNativeWindowHandles(&windowInfo);
s_glHDC = windowInfo.nativeDisplayHandle;
SDL3_SyncGLConfigWindowDimensions(windowInfo);
r_swapInterval.SetModified();
if (r_swapInterval.IsModified()) {
r_swapInterval.ClearModified();
Expand Down Expand Up @@ -575,14 +588,7 @@ void GLimp_SwapBuffers(void) {
if (s_glWindow && s_glWindowServices != NULL && s_glWindowServices->RefreshNativeWindowHandles != NULL) {
renderModuleWindowInfo_t windowInfo;
s_glWindowServices->RefreshNativeWindowHandles(&windowInfo);
if (windowInfo.pixelWidth > 0 && windowInfo.pixelHeight > 0) {
glConfig.vidWidth = windowInfo.pixelWidth;
glConfig.vidHeight = windowInfo.pixelHeight;
}
glConfig.uiViewportX = windowInfo.uiViewportX;
glConfig.uiViewportY = windowInfo.uiViewportY;
glConfig.uiViewportWidth = windowInfo.uiViewportWidth;
glConfig.uiViewportHeight = windowInfo.uiViewportHeight;
SDL3_SyncGLConfigWindowDimensions(windowInfo);
}

R_RendererMetrics_EndPresentPhase(RENDERER_PRESENT_WINDOW_STATE, windowBegin);
Expand Down