Skip to content

Submit an open Vulkan upload batch before releasing deferred destroys #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themuffinator merged 1 commit into from
Sep 22, 2026
Merged

Submit an open Vulkan upload batch before releasing deferred destroys #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/renderer/Vulkan/VulkanDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,6 +1614,14 @@ void VK_Device_DeferDestroy( VkImage image, VkImageView view, VkBuffer buffer, V
}

void VK_Device_FlushDeferredDestroys( int slot ) {
// an upload batch that is still open has recorded copies into images this
// slot may be about to release; the slot fence does not cover it, because
// it is only submitted with the next frame. Submit and retire it first.
if ( vkCtx.uploadBatchOpen && ( vkCtx.numDeferredDestroys[ slot ] > 0
|| vkDeferredDestroyOverflow[ slot ].Num() > 0 ) ) {
VK_Device_FlushUploadBatch();
VK_Device_WaitUploadBatch();
}
const int fixedCount = vkCtx.numDeferredDestroys[ slot ];
for ( int i = 0; i < fixedCount + vkDeferredDestroyOverflow[ slot ].Num(); i++ ) {
const vkDeferredDestroy_t &entry = i < fixedCount
Expand Down