Repository navigation
Give the number-clipboard test's view double the Authored accessor - #190
Conversation
8fb8cd3 made NumberControlView hold its authored properties by pointer and read them through Authored(id). ui_number_clipboard.py compiles that view's validation block unchanged against a Mock, which still had only the map, so the harness no longer compiled ("no member named 'Authored' in 'Mock'") and stopped the Validation Script Smoke job on main and every pull request since. The Mock now offers the same accessor over its map. The production code is untouched, and the test exercises it as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
themuffinator
left a comment
There was a problem hiding this comment.
The two-line mock update matches the production Authored() interface. On current main plus this diff, I reproduced the original missing-member compile failure, then ran the full ui_number_clipboard.py harness successfully on Windows/Clang: four production cases and all thirteen compiled mutation checks passed.
The remaining failure in run 39140732412 is a separate pre-existing harness defect: ui_retained_atlas.py extracts math-using production code without . Adding that include to the generated fixture makes the atlas runtime assertions pass locally; I am landing that maintenance fix alongside this integration. This approval is for the test-double fix and does not claim the complete cross-platform CI matrix has passed.
Problem
The Validation Script Smoke job has failed on
mainsince 2026-10-15 (8fb8cd3e), and so on every pull request since, which skips all platform validation jobs:8fb8cd3e("Build retained views faster and share the loaded model instead of copying it") madeNumberControlViewkeep its authored properties by pointer and read them throughAuthored(id).tools/tests/ui_number_clipboard.pycompiles that view's validation block verbatim against aMock, which still only had the map.Fix
The
Mockgets the sameAuthored(id)accessor over its map. Production code is unchanged, and the test exercises it exactly as before.Testing
python tools/tests/ui_number_clipboard.pynow passes locally. It fails onmainwith the error above.<cstdint>/<cmath>includes, which GitHub's runners don't hit;stock_asset_baseline.pyfailed once while other tests were running in parallel and passed on a rerun.🤖 Generated with Claude Code