Skip to content

Give the number-clipboard test's view double the Authored accessor - #190

Merged
themuffinator merged 1 commit into
themuffinator:mainfrom
akacross:fix/ui-number-clipboard-test
Oct 18, 2026
Merged

themuffinator merged 1 commit into
themuffinator:mainfrom
akacross:fix/ui-number-clipboard-test

Conversation

@akacross

Copy link
Copy Markdown
Contributor

Problem

The Validation Script Smoke job has failed on main since 2026-10-15 (8fb8cd3e), and so on every pull request since, which skips all platform validation jobs:

.tmp/ui-number-clipboard-…/validation.cpp:27:25: error: no member named 'Authored' in 'Mock'

8fb8cd3e ("Build retained views faster and share the loaded model instead of copying it") made NumberControlView keep its authored properties by pointer and read them through Authored(id). tools/tests/ui_number_clipboard.py compiles that view's validation block verbatim against a Mock, which still only had the map.

Fix

The Mock gets the same Authored(id) accessor over its map. Production code is unchanged, and the test exercises it exactly as before.

Testing

  • python tools/tests/ui_number_clipboard.py now passes locally. It fails on main with the error above.
  • To check that nothing later in the same CI step is also broken (CI stopped at this test), I ran all 116 commands from this test onward in the step locally:
    • all pass, except six UI harness tests that this machine's newer clang/libstdc++ rejects for missing <cstdint>/<cmath> includes, which GitHub's runners don't hit;
    • five of those pass with the includes added locally;
    • stock_asset_baseline.py failed once while other tests were running in parallel and passed on a rerun.

🤖 Generated with Claude Code

8fb8cd3 made NumberControlView hold its authored properties by pointer and
read them through Authored(id). ui_number_clipboard.py compiles that view's
validation block unchanged against a Mock, which still had only the map, so
the harness no longer compiled ("no member named 'Authored' in 'Mock'") and
stopped the Validation Script Smoke job on main and every pull request since.

The Mock now offers the same accessor over its map. The production code is
untouched, and the test exercises it as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@themuffinator themuffinator added bug Something isn't working priority: P1 Functional or qualification gap in intended scope; no release-date promise. labels Oct 18, 2026

@themuffinator themuffinator left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two-line mock update matches the production Authored() interface. On current main plus this diff, I reproduced the original missing-member compile failure, then ran the full ui_number_clipboard.py harness successfully on Windows/Clang: four production cases and all thirteen compiled mutation checks passed.

The remaining failure in run 39140732412 is a separate pre-existing harness defect: ui_retained_atlas.py extracts math-using production code without . Adding that include to the generated fixture makes the atlas runtime assertions pass locally; I am landing that maintenance fix alongside this integration. This approval is for the test-double fix and does not claim the complete cross-platform CI matrix has passed.

@themuffinator
themuffinator merged commit 862e2de into themuffinator:main Oct 18, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: P1 Functional or qualification gap in intended scope; no release-date promise.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants