Repository navigation
Fix: Fix empty docx folder being left behind in the notebook folder when discarding .docx files - #205
Open
El1as42 wants to merge 1 commit into
Conversation
… when discarding `.docx` files With `$keepdocx = 1` (default), each page's `.docx` file is removed after conversion, but the notebook's `docx` folder was not, leaving an empty `docx` folder in every converted notebook. Now the `docx` folder is removed after a page's `.docx` file is removed, if the folder is empty. It is created again for the next page. A folder that still contains files (e.g. from a previous run with `$keepdocx = 2`) is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204
With
$keepdocx = 1(default), each page's.docxfile is removed after conversion, but the notebook'sdocxfolder is not. So an emptydocxfolder is left in every converted notebook's folder.Changes
Convert-OneNotePage: after removing the page's.docxfile, remove thedocxfolder if it is empty. It is created again for the next page, so it is gone after the last page. A folder that still contains files (e.g. from a previous run with$keepdocx = 2) is kept. With$keepdocx = 2, nothing changes.Tests:
Convert-OneNotePagetests that the folder is removed if it is empty, kept if it is not empty or with$keepdocx = 2, and that failing to remove it does not halt the conversion. Unit tests pass on Windows PowerShell 5.1 and PowerShell 7.0. In this repo's CI (run on my fork), all jobs that can currently run pass: Windows PowerShell 5.1 (windows-2022) and PowerShell 7.1 to 7.4. The other jobs currently fail for any PR, before checkout: thewindows-2019runner image was retired, and the PowerShell 6.0 to 7.0 container images are too old foractions/checkout(GLIBC_2.28' not found). Also tested on real notebook pages: nodocxfolder is left with$keepdocx = 1, and the folder and.docxfiles are kept with$keepdocx = 2.Note: #195 keeps the
docxfolder when removing a notebook's previous output, so that.docxfiles can be reused. This is compatible, since the folder is only removed when it is empty.🤖 Generated with Claude Code