Repository navigation
Fix: Fix blank lines being added at the end of the markdown file for each image on the page - #210
Open
El1as42 wants to merge 1 commit into
Conversation
…each image on the page Each image reference is renamed by reading the markdown file and writing it back with `Set-ContentNoBom`, which appends a newline. So a page with e.g. 27 images (pen/hand written drawings are exported as one image per stroke) ended with 27 blank lines. Now trailing blank lines are removed before writing the final markdown file, which still ends with a single newline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #207
Each image reference is renamed by reading the markdown file and writing it back with
Set-ContentNoBom, which appends a newline each time. So a page ended with one blank line for each image, e.g. 27 blank lines for a page with a slide and a pen drawing of 26 strokes.Changes
Convert-OneNotePage: remove trailing blank lines before writing the final markdown file. The file still ends with a single newline, appended bySet-ContentNoBomas before. This also covers any other rewrite of the markdown file before that step.Set-ContentNoBomis unchanged, since the final file should end with a newline.Tests: a
Convert-OneNotePagetest that the final markdown has no trailing blank lines. It fails without the fix. Unit tests pass on Windows PowerShell 5.1 and PowerShell 7.0. In this repo's CI (run on my fork), all jobs that can currently run pass: Windows PowerShell 5.1 (windows-2022) and PowerShell 7.1 to 7.4. The other jobs currently fail for any PR, before checkout: thewindows-2019runner image was retired, and the PowerShell 6.0 to 7.0 container images are too old foractions/checkout(GLIBC_2.28' not found). Also tested on real notebook pages: they ended with 26 and 28 blank lines before, and with a single newline now.🤖 Generated with Claude Code