Repository navigation
ci: Move the Go tests from Prow to GitHub Actions - #121
Merged
Merged
Conversation
The Test workflow replaces the Prow jobs pull-appkit-go-test and post-appkit-go-test. It runs go test ./... for a pull request and for a push to master. Like the Prow jobs, it runs only when a Go file or go.mod changes. It also runs when go.sum or the workflow file changes. setup-go reads the Go version from go.mod, so the workflow does not need a change for a Go upgrade. TestLogError removed only the $GOPATH/src/ prefix from the stack traces. The test passed only in a checkout under $GOPATH/src/github.com/theplant/appkit, which is the Prow clone path. GitHub Actions checks out to a different directory, and a local checkout is usually not under GOPATH either. The test now removes the module directory, which it finds from its own source file path. GitHub Actions does not send the failures on master to team-dev in Slack, as the Prow reporter did. Jira: SRE-6511
hcsu
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Test workflow replaces the Prow jobs
pull-appkit-go-testandpost-appkit-go-test. It runsgo test ./...for a pull request and fora push to
master.go.modchanges. It also runs when
go.sumor the workflow file changes.setup-goreads the Go version fromgo.mod, so a Go upgrade doesnot need a workflow change.
Test change
TestLogErrorremoved only the$GOPATH/src/prefix from the stacktraces. The test passed only in a checkout under
$GOPATH/src/github.com/theplant/appkit, which is the Prow clone path.GitHub Actions checks out to a different directory, so the test failed
there. The test now removes the module directory, which it finds from
its own source file path. This change also makes the test pass in a
local checkout outside GOPATH.
Limitation
GitHub Actions does not send the failures on
masterto#team-devinSlack, as the Prow reporter did.
Merge order
Merge this PR first. Then merge the test-infra PR that removes the Prow
jobs, so that the repository always has a test job.
Jira: SRE-6511