fix: derive observability-cloud SDK_VERSION from package.json at build time - #1070
Open
abhithesys wants to merge 2 commits into
Open
fix: derive observability-cloud SDK_VERSION from package.json at build time#1070abhithesys wants to merge 2 commits into
abhithesys wants to merge 2 commits into
Conversation
…d time The hardcoded constant had already drifted (0.0.1 vs manifest 0.0.2), failing the package's own version-match test — and changesets-automated bumps would re-break it on every release. tsdown now injects the manifest version via define, with vitest.config.ts mirroring it for tests; the existing test stays as the guard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…se-mgmt-3-sdk-version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardcoded
SDK_VERSION = "0.0.1"insrc/core/wire.tshad drifted from the manifest (0.0.2), failing the package's own version-match test onmain— and once release automation bumps versions on every train, a hardcoded constant would re-break after every release.wire.tsnow uses an injected__SDK_VERSION__;tsdown.config.tsdefines it frompackage.jsonat build time.vitest.config.tsmirrors the define so tests importing fromsrcresolve it.0.0.1regardless of release), whichchangeset statusconfirms joins the release train.Depends on the changesets PR only for the
.changeset/config the changeset file needs.