Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(dsh): ensure the managed web service on every run #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(dsh): ensure the managed web service on every run #562
Changes from all commits
ebe59b77ee1af4b5a53d7File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user runs
DEVA_DSH_WEB=0 deva.sh dshor setsDEVA_DSH_WORKSPACE_AUTO=0in the host environment, neither value is added toDOCKER_ARGSor the persistent container'sdocker execenvironment; only the wrapper inside the container reads them, so both resolve to their default of1. Consequently the documented opt-outs still launch the service and mutate the workspace registry unless users happen to persist the variables through another configuration mechanism.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the default bridge network,
TCP-LISTENwithout abindoption listens on every container interface, not only on traffic forwarded by Docker's host-loopback publish. Any peer container that discovers this container's bridge IP can therefore connect directly to port 3081 and send a loopbackHostheader accepted by dsh's trust fence, exposing the dashboard and the target container's mounted workspace across the repository's container isolation boundary. Add authentication or network filtering that prevents peer containers from reaching this relay.AGENTS.md reference: AGENTS.md:L3-L5
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.