CRW-160 · Go CI 검사: scope, gate, validate, plugin, contracts - #173
Merged
Merged
Conversation
CRW-160 todo 47 (Go half). `crw-dev ci {scope, gate, validate, plugin, contracts, operations}` is a separate binary behind build tag `dev` (cmd/crw-dev, internal/dev/ci); release builds contain only crw. Each check reproduces its Python script - scripts/ci/{scope,gate,validate,plugin,contracts}.py and scripts/check_operations_contract.py - and ci.yml's selection, validate and dev-gate jobs now build and call it. The gate's required-job list is unchanged (gate.py JOBS, Go GateJobs and ci.yml needs are the same six jobs).
By property: 36 contract properties of test_gate, test_plugin, test_scope and test_validate map to Test47_<ID> tests that run the Python script and the Go command on the same inputs and require the same exit code, stdout and stderr; test_packages' two properties are Python-internal. Parity holds at HEAD and on about thirty failing inputs; the remaining differences are tracebacks versus one-line errors on paths no workflow parses.
Deferred by the orchestrator to the step before todo 48: deleting the Python scripts, scripts/ci/tests, pyproject.toml and uv.lock, and the three python3 lines ci.yml still runs, because todos 21-45 keep using uv for Python parity.
Independent checker confirmed round 2 (6/6 mutations). Clean copy: uv sync --locked, make lint, make test, make contract, go test -tags dev, make dist (crw only), and the Python and Go validate/plugin/contracts checks exit 0; scripts/ci/tests pass in the worktree.
thisisjun786
marked this pull request as ready for review
September 26, 2026 14:24
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRW-160 · crw-go-port todo 47의 Go 쪽 작업입니다. wave 2 통합 브랜치(#172) 위에 쌓인 브랜치입니다.
내용
crw-dev ci {scope, gate, validate, plugin, contracts, operations}:dev빌드 태그로만 만들어지는 별도 바이너리입니다. 릴리스 아카이브에는 들어가지 않고,make dist는crw만 만듭니다.검증
일부러 남긴 것
Python 스크립트,
scripts/ci/tests,pyproject.toml,uv.lock과 ci.yml의python33줄은 todo 48 직전 단계에서 지웁니다. todo 21-45가 Python 비교 테스트에 uv를 계속 씁니다.Plan: .omo/plans/crw-go-port.md