Skip to content

CRW-154 · Go relay registry: 등록, 설정 보존, assignment - #174

Merged
thisisjun786 merged 3 commits into
devfrom
codex/crw-154-registry
Sep 26, 2026
Merged

thisisjun786 merged 3 commits into
devfrom
codex/crw-154-registry

Conversation

@thisisjun786

@thisisjun786 thisisjun786 commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

CRW-154 · crw-go-port wave 3 registry 트랙입니다. wave 2 통합 브랜치(#172) 위에 쌓인 브랜치입니다.

포함된 todo

  • 25 24972404: registration, settings 보존, generation, relationship 상태, assignment, dispositions, role policy. crw relay와 codex-session-relay 링크 양쪽에서 Python과 같은 사용법과 종료 코드로 동작합니다.

검증

  • 독립 checker가 확인했습니다. 132개 성질이 모두 Go 테스트로 옮겨졌고, 22개 표본 중 21개가 Python과 동등하며, 뮤테이션은 16개 중 14개가 잡혔습니다. 놓친 2개는 다른 todo가 맡는 경로입니다.
  • todo 25 명령만 쓰는 cli-shape fixture 51개가 strict 모드에서 통과합니다.
  • 클린 카피에서 uv sync --locked, make lint, make test, make contract, check_*가 모두 exit 0입니다.

남은 일

이 브랜치에서 todo 26(linkage, merge-turn), 27(capacity, edit region, managed-start), 28(bridge adapter)이 이어집니다. 끝날 때까지 draft로 둡니다.

Plan: .omo/plans/crw-go-port.md


Devin Review

…ents

CRW-154 todo 25. internal/relay/registry ports registry.py, settings.py, rolepolicy.py, policy.py, assignment.py, dispositions.py and coordination.py: register (23 flags), settings-record/show, generation-open/bind, admit-turn, relationship-status/resume, assignment-show/find/mark and dispositions-show, dispatched from the relay CLI so both `crw relay <cmd>` and the codex-session-relay link reach them with Python's usage and exits. Settings preservation keeps SETTINGS_NOT_PRESERVED / SETTINGS_DIFFER_AFTER_LOAD; the registration write hold is taken before the decision, as Python's registration_hold does; role policy goes through internal/bridge/execution with Python's per-process snapshot.

By property (Jun's basis): the contract/behaviour properties of test_registry, test_cli, test_register_atomicity, test_registration_contention, test_registration_hold, test_settings_preservation, test_settings_hold_naming, test_assignment, test_dispositions and test_rolepolicy map to Go tests that compare whole JSON answers and CLI stdout with the live Python relay; dispositions-show matches 51 cli-shape fixtures byte for byte. Properties whose surface belongs to other todos moved there (21C, 24B, 29, 33).

Squashed from the part A/B work on the registry track. Independent checker confirmed. Clean copy: uv sync --locked, make lint, make test, make contract and check_test_map exit 0.
@thisisjun786
thisisjun786 marked this pull request as ready for review September 26, 2026 14:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-26T14:48:44.337267Z 2497240 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread internal/relay/cli/registry.go
@thisisjun786
thisisjun786 merged commit 602e114 into dev Sep 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant