Skip to content

feat(relay/delivery): delivery, intent, admission, reconcile and recover (todo 21, CRW-153) - #175

Merged
thisisjun786 merged 5 commits into
devfrom
codex/crw-153-delivery
Sep 26, 2026
Merged

thisisjun786 merged 5 commits into
devfrom
codex/crw-153-delivery

Conversation

@thisisjun786

Copy link
Copy Markdown
Owner

Todo 21 of crw-go-port (CRW-153): delivery, intent, admission, reconcile and recover, one squashed commit on codex/crw-go-port-w2.

  • Properties: 216 ids, 213 ported to named Go tests compared with real Python output, 3 python-internal (DRL-0, VCU-5, USL-18); plus the six test_attempt_message_atomicity cases handed over from todo 18.
  • Independent checker: 213/213 mapped, 13/16 mutations caught; the one defect (attempt-message order unpinned) is fixed and its mutation now fails a test. The emit/deliver/claim/ack round trip gives the same stdout, exit codes and rows as the Python CLI except timestamps.
  • Subsets owned by later todos: internal/relay/faults (todo 22), internal/relay/mergeturn (todo 26), marked in their package docs.
  • Deferred by plan: --socket host paths (todo 28), daemon tick (29), composed report (24), merge-turn writes (26), settings-hold projection (25). Strict cli-shape still skips 75 fixtures owned by other todos; strict hook waits for todo 33.
  • Clean-copy gate on 18c6b3c: uv sync --locked, make lint, make test, make contract all exit 0.

Draft; do not merge without Jun.

Port todo 21 of crw-go-port: delivery emit/deliver/claim/ack/verdict,
intents and markers, admission, reconcile and recover, host-loss and
unknown-send handling, ACK/re-review/recovery paths, with one Go test per
contract/behaviour property (216 ids, 213 ported, 3 python-internal) plus the
six attempt-message cases handed over from todo 18, each compared with real
Python output. Subsets of faults (todo 22) and mergeturn (todo 26) are
marked with their owners.
@thisisjun786
thisisjun786 marked this pull request as ready for review September 26, 2026 14:43
@thisisjun786
thisisjun786 changed the base branch from codex/crw-go-port-w2 to dev September 26, 2026 14:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-26T14:48:25.883282Z 18c6b3c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Devin Review

Comment thread internal/relay/delivery/reconcile_pass.go Outdated
@thisisjun786
thisisjun786 merged commit 0120621 into dev Sep 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant