Skip to content

feat(calendar): unit calendar and iCal feeds #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Clupai8o0 wants to merge 3 commits into
base: 11.0.x
Choose a base branch
from
Open

feat(calendar): unit calendar and iCal feeds #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c524ce1
feat(calendar): unit calendar and iCal feeds
Clupai Sep 27, 2026
52e92a7
feat(theme): page redesign for the calendar files
Clupai Sep 27, 2026
dbc766e
feat(calendar): bring in org web PR 281 for the calendar files
Clupai Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions docs/CAL-A01-accessibility-verification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# CAL-A01: Calendar accessibility verification

## Changes and automated evidence

The download options dialog focuses its first control (Grade) when it opens. Material supplies the focus trap, Escape handling and focus restoration. The result count and empty-result message share a persistent `role="status"` region, so changing a filter can announce whether a download is available. Decorative icons are hidden from the accessibility tree.

The Web calendar switch, loading spinner and reminder save/cancel actions have explicit accessible names. Included units use ordinary chips with named native removal buttons; the add-unit menu has a visible **Add unit** button. These actions retain their saving guards. The subscription link, copy and regenerate controls retain their separate names and behaviors.

`calendar-modal.component.spec.ts` renders the actual Material chips, menu trigger and switch and checks names, removal activation and disabled states. `download-filter-dialog.component.spec.ts` checks the live result region and empty state. `task-planner-card.component.spec.ts` checks the initial-focus configuration along with the grade/status/date download guards.

These are DOM/component checks. They do not establish screen-reader output, rendered contrast, browser Tab order or a completed manual accessibility audit.

## Observed keyboard pass — 21 September 2026

The real local application was exercised with keyboard input only, in a Chromium browser at web `283b49336`, using the [synthetic fixture](calendar/evidence-20260921/environment.md). This was a keyboard pass, not a screen-reader audit.

- Enter on **Download .ics** opened the dialog with focus on **Grade**. Home and arrow keys selected the grades; Space changed the grade range and exclusion checkbox.
- Tab moved from Grade to the selected grade-range radio, then the exclusion checkbox, then Cancel. With a valid result the Download button was available.
- Pass / Up to this grade / exclusion on produced the empty message and disabled Download. Tab from Cancel skipped that disabled button and wrapped to Grade.
- Escape, Cancel and a successful download returned focus to the dashboard's **Download .ics** opener.
- In Web calendar, the first loading state focused Close. Tab reached **Enable web calendar** after loading; Space enabled it. Saving temporarily disabled the affected controls. Unit removal and the Add unit menu were keyboard operable.
- At a 390 × 844 viewport, all download options and both action buttons were visible without horizontal clipping. The normal viewport was restored afterward.

![Empty result and disabled Download](calendar/evidence-20260921/keyboard-empty-state.png)

![Download options at phone width](calendar/evidence-20260921/keyboard-mobile-download.png)

The first native-app attempt paused when the Mac locked. It resumed after the Mac was unlocked, but no successful screen-reader session or recording has been verified. Accessibility-tree text is not evidence that a screen reader announced it. **CAL-A01 remains open** for the screen-reader session and recording.

### Resumed attempt and current environment blocker

On the resumed attempt, VoiceOver was switched on in macOS settings but did not start; two direct launch attempts timed out. No actual VoiceOver speech or live caption output was observed. OBS 32.1.2 crashed during initial scene creation and was recovered in Safe Mode. An empty **OnTrack CAL-A01 Evidence** scene was added and Mic/Aux was muted, but no recording was started.

The test machine then stopped responding to native input, which prevented further testing or cleanup. VoiceOver could not be confirmed as turned off, so its final setting is unverified. These are test-environment failures, not evidence that the calendar controls passed or failed screen-reader use. A working test machine is required to verify the setting, complete the actual screen-reader pass and attach the recording to the PR.

## Remaining validation

Use synthetic student data. Record browser, OS and screen-reader versions, date, viewport and the commit tested. Do not put real subscription tokens in recordings.

1. Tab to **Download .ics**, press Enter and confirm Grade receives focus. Change each grade with the keyboard, change Grade range and the submission checkbox, and confirm the count is announced once after each change.
2. Select a zero-result combination. Confirm the explanation is announced and Download is disabled. Restore a valid selection and download with Enter/Space.
3. Open again and press Escape. Confirm focus returns to **Download .ics**. Repeat using Cancel.
4. Open Web calendar and toggle it with Space. Confirm the enabled/disabled state is announced. Navigate unit removal, Add unit, reminders, subscription link, Copy, Regenerate, Download a copy and Close without a pointer.
5. Trigger a save and verify disabled controls cannot activate. Check confirmation dialog focus and return focus after cancellation.
6. Repeat at 200% zoom and a phone-width viewport. Check focus visibility, scrolling and no horizontal clipping. Repeat in the supported light/dark themes.

The checklist above is the full repeatable procedure; the observations in the preceding section identify the portions already exercised. The 200% zoom, theme variants, full WebCal control traversal, confirmation focus and spoken announcements remain unverified. Add the recording and actual observations before marking the ticket complete.
96 changes: 96 additions & 0 deletions docs/CAL-C01-calendar-compatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
# CAL-C01: Calendar compatibility evidence

**CAL-C01 is complete.** The four-event fixture was imported and checked in Apple Calendar, Google Calendar and Outlook on the web on 21 September 2026. All three showed the intended single all-day dates. Client-specific Unicode/newline display behavior is recorded below.

## Reproducible fixture

[calendar-compatibility.ics](calendar/calendar-compatibility.ics) is generated by the production frontend `buildIcsCalendar` function using synthetic tasks and a fixed `DTSTAMP` of 2026-09-20 00:00 UTC. It contains no account, subscription token or real student information.

| UID | Expected title/details | Expected all-day date | Exclusive end |
| -------- | --------------------------------------------------------------------------------- | --------------------- | ----------------- |
| E-900001 | CAL-TEST: 1P: Year boundary | 31 December 2026 | 1 January 2027 |
| E-900002 | CAL-TEST: 2C: Melbourne daylight saving starts | 4 October 2026 | 5 October 2026 |
| E-900003 | CAL-TEST: 3D: Leap day | 29 February 2028 | 1 March 2028 |
| E-900004 | Unicode café, calendar emoji, escaped punctuation, newline and long Unicode title | 20 September 2026 | 21 September 2026 |

The automated frontend suite covers civil-date preservation at leap-year, daylight-saving and year boundaries; CRLF line endings; 75-octet UTF-8 folding; escaping; stable task-definition UIDs; invalid-date exclusion; and every grade range. See [CAL-T01](CAL-T01-test-coverage.md) for the exact test command and results.

To regenerate the fixture from a dependency-installed checkout:

```sh
node_modules/.bin/esbuild src/app/api/services/ics-calendar-builder.ts --bundle --platform=node --format=cjs --outfile=/tmp/ontrack-calendar-builder.cjs
node docs/calendar/generate-fixture.cjs /tmp/ontrack-calendar-builder.cjs
```

The generator supplies only synthetic task objects; the real event/date/escaping logic comes from the compiled production builder. Its timestamps and dates are fixed, so regenerating the file should produce no diff. A local `.gitattributes` entry preserves the fixture's required CRLF line endings in Git.

## Client results recorded on 21 September 2026

The four-event compatibility fixture was imported into real calendar applications. This is separate from the [six CAL101 option-filter downloads](calendar/evidence-20260921/exports/README.md), which demonstrate grade and submitted-task filtering.

| Client | Import result | Date and text verification | Evidence |
| --- | --- | --- | --- |
| Apple Calendar | Four fixture events imported | All four appeared on the intended all-day dates, without an extra day; Unicode title value checked through native accessibility text | Native Calendar screenshots below |
| Google Calendar | Application reported 4 of 4 events imported; all four original events verified | Exactly four results on the intended single all-day dates; Unicode and punctuation retained, with the newline displayed as a space | Search, daylight-saving and Unicode screenshots below |
| Outlook Calendar | Import confirmation observed; selected-calendar search returned exactly four events | All four had the intended single all-day date; Unicode and punctuation retained with client-specific newline display normalization | Four-event search screenshot and text observations below |

The Apple test used **Calendar 27.0 (3073)** on **macOS 27.0**, with the system timezone set to **Australia/Melbourne**. The Google import and follow-up verification used **Chrome 153.0.8010.48** on **macOS 27.0**. Its day grid displayed **GMT+10**; the Google Calendar account's configured timezone was not confirmed, so this report does not claim a Melbourne timezone setting for Google. Outlook on the web was also tested in native Chrome on macOS 27.0; its account's configured timezone was not confirmed. These are observed all-day civil-date results, not a claim about either web client's configured timezone.

### Apple Calendar observations

| Fixture case | Observed all-day date | Screenshot |
| --- | --- | --- |
| Unicode, escaped punctuation and long title | 20 September 2026 | [Unicode event](calendar/evidence-20260921/apple-unicode.png) |
| Melbourne daylight-saving start | 4 October 2026 | [Daylight-saving event](calendar/evidence-20260921/apple-dst.png) |
| Year boundary | 31 December 2026 | [Year-boundary event](calendar/evidence-20260921/apple-year-boundary.png) |
| Leap day | 29 February 2028 | [Leap-day event](calendar/evidence-20260921/apple-leap-day.png) |

Each event occupied its intended day rather than continuing into an additional day. The Unicode event retained its complete title in the native accessibility value, including the accented text, emoji, punctuation, backslash and line break. Its long title is visibly truncated by the event-detail viewport; the screenshot therefore does not show the entire title at once.

![Imported Unicode event on 20 September 2026 in Apple Calendar](calendar/evidence-20260921/apple-unicode.png)

### Google Calendar observations

The original import reported **Imported 4 out of 4 events** in **OnTrack CAL-C01 Test 2026-09-21**. Before the detailed checks, one accidentally deleted synthetic event was restored from that dedicated calendar's Trash. The original imported events were then verified without re-importing or creating duplicates.

On 21 September 2026, searching for `CAL-TEST` returned exactly four results. Each result was labelled **All day** and showed only the intended single date:

| Fixture case | Observed all-day date |
| --- | --- |
| Unicode, escaped punctuation and long title | 20 September 2026 |
| Melbourne daylight-saving start | 4 October 2026 |
| Year boundary | 31 December 2026 |
| Leap day | 29 February 2028 |

![Exactly four Google Calendar results on the intended all-day dates](calendar/evidence-20260921/google-four-events.png)

The daylight-saving event's [day view and detail popup](calendar/evidence-20260921/google-dst.png) confirmed 4 October. The Unicode event's complete accessible name retained **café**, the calendar emoji, comma, semicolon, literal backslash and all 40 trailing **é** characters. Google's UI displayed the embedded newline as a space. The [detail popup](calendar/evidence-20260921/google-unicode.png) visually shortened the long title with an ellipsis; the complete accessible name was checked separately.

Only the dedicated test calendar was enabled during verification. The seven original calendar visibility settings were restored afterwards. The retained captures show synthetic test-event content and no private email addresses.

### Outlook Calendar observations

On 21 September 2026, a blank calendar named **OnTrack CAL-C01 Test 2026-09-21** was created in the existing enterprise Outlook web application. The creation UI identified the new calendar as not visible to other people. **Upload from file** imported the same `calendar-compatibility.ics` fixture into that calendar, and Outlook displayed a successful import confirmation naming the file and destination. The attempted toast screenshot did not capture that confirmation and is not included as evidence.

With only the test calendar selected, searching **Selected calendars** for `CAL-TEST` returned exactly four events. Each result was labelled **All day** and showed one date:

| Fixture case | Observed all-day date |
| --- | --- |
| Unicode, escaped punctuation and long title | 20 September 2026 |
| Melbourne daylight-saving start | 4 October 2026 |
| Year boundary | 31 December 2026 |
| Leap day | 29 February 2028 |

![Exactly four Outlook results on the intended all-day dates](calendar/evidence-20260921/outlook-four-events.png)

The full accessible list title retained **café**, the calendar emoji, comma, semicolon, literal backslash and all 40 trailing **é** characters. Outlook normalized the embedded newline to whitespace in the list. Inspecting the Unicode event without changing or saving it showed **Sun 20/09/2026 (All day)**. Its title field removed the newline rather than replacing it with a space, joining that boundary as `andline breaks`; the list displayed `and line breaks`. The other tested title characters remained present. This is a client display-normalization observation, not an exact-newline-preservation result.

The event pane was not captured because it exposed an account email address; the retained list screenshot shows only the four test entries. The personal calendar was deselected for the checks and its original visibility was restored afterward. No existing event was edited.

Subscription refresh is a separate operation: an imported file never refreshes. Live-feed observations belong in [CAL-D00](CAL-D00-webcal-feed-test.md); the successful file-import checks do not establish that a subscription updates correctly.

## Live-feed difference that needs special attention

The API WebCal feed and **Download a copy** use the server serializer, while the unit **Download .ics** uses the frontend builder. On the tested API commit `d7f7a5b9c2d34ef279ac3a70bc58823def64005c`, task events set `DTEND` equal to `DTSTART`. The frontend uses an exclusive next-day `DTEND`. Test the live feed separately: a successful unit-file import does not validate the server's zero-duration all-day representation. The live feed also has optional timed HelpHub/class events, start dates and alarms absent from this frontend fixture.

This report does not change the server contract or claim the existing feed works in a particular client without an observed result.
Loading