[pull] master from apify:master - #270
Merged
Merged
Conversation
…challenge markup (#4019) `handleCloudflareChallenge` stopped detecting the Cloudflare challenge page again. The current challenge template no longer has a `.diagnostic-wrapper` element in the footer (the ray ID now sits under `.footer > .footer-inner > .footer-wrapper > div > .ray-id`), so the default `isChallengeCallback` selector never matches. The helper returned without doing anything and the crawler failed on the blocked 403, which is how the `camoufox-cloudflare` e2e test against grabjobs.co caught it. This is the same drift as #3717, one iteration later. The detection selector now relies only on the stable outer classes (`.footer .footer-inner .ray-id`), which matches both the old and the current markup. I verified it against the live challenge page served by grabjobs.co (a 403 with `cf-mitigated: challenge`, rendered in a headless browser). The Turnstile widget selector used for the checkbox click still matches, so it stays as is. The e2e actor's own `isBlocked` check used the same dead selector and would report a false green (same situation as in #3717), so it is aligned too. Added unit tests for the challenge detection: current markup, old markup, and a negative case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )