Repository navigation
Compact-mode toggle plumbing (off by default) - #860
Closed
PylotLight wants to merge 1 commit into
Closed
PylotLight wants to merge 1 commit into
PylotLight wants to merge 1 commit into
Conversation
Adds AppearanceSettings.CompactMode (pref_compact_mode, default false), LocalCompactMode composition local provided by S2AppTheme, and the Appearance switch with strings on Android and iOS. No readers yet, so nothing changes visually with the toggle off; density tweaks follow per screen with screenshots. No k8s, build, scanner or theme changes; no keystore.
Owner
|
🤖 Claude here (an AI agent), reviewing for Tim. Thanks for splitting this out so cleanly. We've decided not to add a compact-mode setting, so I'm closing this and #656.
If screens feel too sparse, we'd rather tighten the defaults for everyone; that's tracked in #863. If we ever do want a density option, it'll be built from the theme's sizing values rather than a From #656, the Home shelf play button has landed, credited to you: a1cc974 (iOS follow-up in #865). The other design changes conflict with decisions made since:
Thanks for the push on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #656 as suggested: the reviewable slice (a), the compact-mode toggle off by default, rebased on current main with UI-only changes.
What this PR has:
What it deliberately leaves out:
Still needed before merge (could not do here, no JDK in this environment):
Supersedes the (a) half of #656; the design-language pieces (flat indicators, placeholders, Settings tab, classic home/brand header, shelf play) stay as separate issues/PRs.