chore: bump to v0.17.1 - #436
Merged
Merged
Conversation
Patch release for six PRs merged after v0.17.0: help/kaish-tools nested-subcommand recursion, the wrapped-command allow_external_commands framing correction, a changelog correction plus a new zero-padded date/time migration note, nested verb groups for wrapped commands, mount-point ancestor navigation when a backend also covers /, and VfsRouter-shared path canonicalization that closes a containment leak in readlink -f/realpath. kaibo's release-gate review (deepseek) found no undocumented semver breaks — the two new canonicalize trait methods are defaulted and the changed public types are either #[non_exhaustive] or privately fielded, so the patch framing holds. It did catch two doc inaccuracies, fixed here: EMBEDDING.md claimed realpath passes allow_missing_final: true and rechecks existence, when it actually passes false directly; and the canonicalize changelog entry overstated the default implementation as containment-checked, when containment is actually a property of LocalFs's and VfsRouter's overrides, not the shared default. Two smaller findings — a wrapped-command node silently accepting a no-op json_output declaration, and thin test coverage on the new canonicalize default's symlink-hop cap — are real but scoped as code changes rather than release-blocking text, so they're queued for a follow-up rather than folded into this bump. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: kaibo (deepseek/deepseek-v4-pro) <noreply@kaibo.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and changelog stamp for v0.17.1, a patch release covering six PRs merged since v0.17.0: help/kaish-tools nested-subcommand recursion (#430), the wrapped-command allow_external_commands framing correction (#431), a changelog correction plus a new zero-padded date/time migration note (#432), nested verb groups for wrapped commands (#433), mount-point ancestor navigation when a backend also covers
/(#435), and VfsRouter-shared path canonicalization closing a containment leak inreadlink -f/realpath(#434).This bump also carries two documentation fixes surfaced by the release-gate review below rather than opening a separate PR for text-only changes:
docs/EMBEDDING.mdclaimedrealpathpassesallow_missing_final: trueand rechecks existence, when it actually passesfalsedirectly; and the canonicalize changelog entry overstated the default implementation as containment-checked, when containment is a property ofLocalFs's andVfsRouter's overrides, not the shared default.Reviewed with kaibo (
consult, castdeepseek) against the fullv0.17.0..HEADdiff. Verdict: no undocumented semver breaks — the two newcanonicalizetrait methods are defaulted and every changed public type is either#[non_exhaustive]or privately fielded, so the patch framing holds. Two smaller findings from that review are real but scoped as code changes rather than release-blocking text, so they're queued as follow-up work rather than folded into this bump: a wrapped-command node can silently accept a no-opjson_outputdeclaration instead of being refused, and the newcanonicalizedefault's symlink-hop cap has thin test coverage.Gates:
cargo test --all(2231 passed),cargo clippy --all --all-targets -- -D warnings(clean),cargo insta test --check(no pending snapshots).