Skip to content

Prevent possible None dereferences in texture recoloring #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zaktherobot merged 1 commit into from
Aug 31, 2026
Merged

Prevent possible None dereferences in texture recoloring #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Module/cosmeticsmods/texture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ def recolor_textures(self) -> list[ModAsset]:
return assets

base_path = appconfig.extracted_game_path("kh2")
if not base_path.is_dir():
print(f"Could not find extracted data at {base_path} - not recoloring textures")
if base_path is None:
print(f"Could not find extracted KH2 game data - not recoloring textures")
return assets

recolorable_models = self.load_recolorable_models()
Expand Down
4 changes: 2 additions & 2 deletions UI/Submenus/TextureRecolorSettingsDialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ def __init__(self, seed_settings: SeedSettings):
self.conditions_loader = TextureConditionsLoader()

self.base_path = appconfig.extracted_game_path("kh2")
if not self.base_path.is_dir():
if self.base_path is None:
# Really shouldn't be able to get here without something weird going on, just note it and return
print(f"Could not find extracted data at {self.base_path}")
print(f"Could not find extracted KH2 game data")
return

all_models = TextureRecolorizer.load_recolorable_models()
Expand Down
Loading