Repository navigation
feat(core): fold a squash from a bare alignment of its spine - #270
Merged
Merged
Conversation
10 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115.
Adds the verb
squash, which takes one bare alignment, a line of the spine onto a line or a point (ADR 0038), and folds the squash through the fan solver (ADR 0044). The solver is split from the resolution of the items offlatten, so the squash hands it resolved rays, an anchor and a stayer. The reference pages state the verb on the language, model and kernel pages, and the tree-sitter grammar parses it.Decisions the records left to the build, reviewed on a page of sections and crease patterns:
squashtakes no further item.On the preliminary base
squash (--h onto --ac)fails as ambiguous, and the hint offers(--h & --da onto --ac)and(--h & --bc onto --ac). The squash of one flap gives the state offlatten-squash-on-folded-base.belwith ten faces in place of its twelve: the explicit program scored its marks across the whole sheet, and the squash scores the axis from the vertex on.The review needed drawings the renderer could not make, so the branch also carries them:
--highlighton the render command line; in the section view, unnamed hinges labelled by the line that scored them and parts colored by highlighted flap; the point that names a flap drawn in the flap's color, in captions too; a lightbox for the figures of the site; and the stayer of a fan found and drawn where its sector is wider than a half-turn, which the trace and the op view got wrong before.