Repository navigation
1.9.79: the release notes list each 1.9.79 change once - #330
Open
tracking202 wants to merge 3 commits into
Open
tracking202 wants to merge 3 commits into
tracking202 wants to merge 3 commits into
Conversation
1.9.79's PHPStan job has been red since the merges at 15:46Z. #308 extended ForbidNumericCastOfRequestParamRule to the pages and baselined the casts already there. Three PRs merged beside it each added a cast that its baseline does not count, and each PR passed on its own: - Personal settings (#283) cast the same-IP fallback after checking it is a key of its choices. It now stores 1 for '1' and 0 for '0', the two keys the check admits. - Setup > Offline Conversions (#293) cast a feed id after a regex test. It now reads it with PostedId::read(). - Setup > Traffic Sources (#271) cast the edited account's id to read its stored postbacks. The page's own ownership check compares the raw value in SQL, where MySQL reads '12abc' as 12. So a save from ?edit_ppc_account_id=12abc changed account 12 (one of the account's own, not the one named) and held that account's postbacks. Measured on a live instance: the old page saved the tampered edit onto account 1. The id is now read exactly, and anything else is refused in the page's words before anything is read or written. The baseline counts are unchanged: each file now holds only the casts they counted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRoS2SViuxaucFaKWsFnLr
Every 1.9.79 PR added its lines at the end of the version's list, so every merge of two of them conflicted there. Resolving by keeping both sides kept a line both sides already had, and kept the older wording of a line one side had reworded. Under Version 1.9.79, changelogs.txt held 124 entries and 81 changes: - 35 entries were exact repeats. PayKickstart's IPN was listed four times; JVZoo, ClickBank and the LTV webhooks three times each. - 8 were an older wording kept beside the newer. The newer wording is the one each change's merged PR head carries: a deleted account's stored keys verify nothing (PayKickstart, JVZoo, ClickBank), a second ClickBank refund is refused, Google's one-second rule in the offline files, P202_SERVER_STATE_DIR per install, and switching a user off revoking their remember-me keys. Each change now has one entry, at the place its first copy held, in the wording its PR ended with. Nothing outside 1.9.79 changes. changelogs.json had no repeats. ChangelogEntriesAreUniqueTest refuses a repeated entry in any version of either file; every released version passes. For the version version.php names, it also refuses two entries sharing 60% of their five-word runs. On 1.9.79 every reworded copy scored 0.76 to 0.97, and the closest two distinct changes 0.18. That check does not cover released versions: 1.9.56 lists one change as both an Update and a Fix (0.78), and it shipped that way. Planted with the merged file it fails both tests; with only the eight reworded copies it fails the wording test, naming all nine pairs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRoS2SViuxaucFaKWsFnLr
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1.9.79's PHPStan job is red on its own tip: three request casts that its merges left. #328 fixes them, and it is merged here so this branch's PHPStan check runs green. When #328 merges into 1.9.79, the commit is already there and this merge adds nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRoS2SViuxaucFaKWsFnLr
Owner
Author
|
What is red here, and why it is not this PR's:
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every 1.9.79 PR added its release-note lines at the end of the version's list, so every merge of two of them conflicted there. Resolving by keeping both sides kept two things:
Under Version 1.9.79,
changelogs.txtheld 124 entries for 81 changes:P202_SERVER_STATE_DIRper install;Each change now has one entry, at the place its first copy held, in the wording its PR ended with. The removed set is exactly those 43 copies (checked by script): no entry is added or reworded, and nothing outside 1.9.79 changes.
202-config/changelogs.jsonhad no repeats and is untouched.The check
tests/Release/ChangelogEntriesAreUniqueTest:version.phpnames, two entries that share 60% of their five-word runs are refused. On 1.9.79 every reworded copy scored 0.76 to 0.97, and the closest two distinct changes scored 0.18.Plants:
changelogs.txtput back, both tests fail.cmp, and the suite was re-run green.The merge tool that produced most of these was the coordinator's changelog resolver. It kept the incoming side's copy of a line this branch had reworded. It now drops it, in both the text and the JSON resolver.
No backlog item: K2SP's agent found it on 1.9.79 after the merges, and I counted it.
Verification
Run in a worktree at 8288e8b (origin/1.9.79 c6d5167 plus this commit), PHP 8.3.
.claude/skills/p202-verify/scripts/verify.sh --changed, run before the four long lines in the new test were wrapped:phpcs --standard=PSR12on the file is now clean.account.php,offline_conversions.phpandppc_accounts.php, red on c6d5167 alone. 1.9.79: read the three request values 1.9.79's own merges left cast (PHPStan red on 1.9.79) #328 fixes them. PHPStan on the new test file reports nothing.There is no live or agent path: this is the release-notes text and a test.
Generated by Claude Code