Repository navigation
CI: review workflows on master match 1.9.79's, so 1.9.79 PRs are reviewed again - #341
Merged
Merged
Conversation
…are reviewed again Claude's GitHub app runs a review only when the workflow file the PR runs is identical to the one on the default branch. 1.9.79 changed adversarial-review.yml (0befdee, 6834377) and claude-code-review.yml (80f983c, 6834377), so every PR against 1.9.79 since then was skipped: 'Workflow validation failed. The workflow file must exist and have identical content to the version on the repository's default branch', then 'the adversarial review did not run' (#331, #332, #334, #335, #336). This takes both files from 1.9.79 unchanged. They read nothing master lacks: .github/review-findings-key.asc is the same file on both, and the review reads CLAUDE.md from the PR's own branch.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The adversarial review and Claude Code Review checks have not run on any PR against
1.9.79since 1.9.79 changed their workflow files: #331, #332, #334, #335 and #336 all show it, and those PRs merged with the check red. The step log says:Claude's GitHub app runs only a workflow whose file is identical to the one on
master. 1.9.79 changedadversarial-review.yml(0befdee, 6834377) andclaude-code-review.yml(80f983c, 6834377), so on every 1.9.79 PR the file differs from master's, the action skips, and the next step reports 'the adversarial review did not run'.Change
Both files taken from
origin/1.9.79unchanged (blob-identical). Nothing else they need is missing on master:.github/review-findings-key.ascis the same file on both branches, and the review readsCLAUDE.mdfrom the PR's own branch.This PR's own review is skipped for the same reason (it changes the workflow), which the app says is expected.
After merge
Re-run the review checks on the open 1.9.79 PRs (#338, #339 at least). PRs already merged without a review (#331-#336) can be reviewed by hand, or by re-running the workflow on their merge commits.