Skip to content

Keep conversation graph reconciliation independent of unrelated invalid proposals #439

Description

@adrianwebb

Objective

A legacy accepted proposal must never run after its exact TreeDX content fails the current schema, but it also must not prevent unrelated new proposals or conversations from entering the one team graph.

Evidence

SDK guest smoke send-1ee720f62db3363963dfeb587337af0b repeatedly retried without assignment because a team-wide conversation reconciliation reread accepted retry-31 with request as an array. Scoped conversation reconciliation plus package-owned real Kata smoke passed. Fresh SDK BY proposal then failed after TreeDX authoring because team-wide proposal reconciliation met the same old content. Subsequent plan checks found v4 and v4-parallel; v4 ready nodes belonged to a cancelled simulation, while v4-parallel retained an unassigned ready Reviewer. The graph currently has thousands of historical nodes, so a correlated per-node assignment scan is too costly.

Required behavior

  • One graph, source authority and assignment path; no alternate orchestration.
  • New conversations project their own nodes without reinterpreting unrelated proposals.
  • For malformed accepted historical content with already-materialized nodes and no active assignment, retain its exact graph component but block any ready nodes. Do not silently admit it or delete decision history.
  • Unmaterialized invalid accepted content, live assignments, TreeDX outages, and authority mismatches remain fail-closed.
  • Read active assignment state once, not once per graph node.
  • Add focused source/graph tests and real read-only graph-plan plus guest-smoke evidence. Bound failed conversation admission retries in a follow-up if still reproducible.
  • Repair proposal authoring so a post-TreeDX graph error cannot leave an orphaned source path without a recoverable governance binding.

Delivery

API PR #438 head 387fc86. Local API build and 1,233 tests pass, 20 existing skips. Real guest smoke passed after scoped conversation activation. Read-only graph plan and fresh SDK golden still pending latest development activation. PR verify requires compatible staged SDK viability-floor contract; do not merge failing required checks or cut an RC before local acceptance.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions