fix: prepare managed candidates before stopping healthy development services - #232
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
A failed caller-owned candidate build no longer stops the healthy managed service or switches away from its live route. Refresh generated command metadata against accepted SDK usage pagination.
Work authority
Platform #520; explicit user authorization for complete component and lifecycle regressions. Base f3072e7; head 9fd30dc.
Plan
Prepare the private candidate before stop, remove duplicate post-stop build, assert failed preparation retains runtime/route using the real CLI entrypoint, execute the existing scene and package gates. No RC/tag.
Changes and commits
56b7df4 and 9fd30dc; no new lifecycle authority, flags, or compatibility layer.
Verification
210 tests passed with exact accepted SDK artifact daebc1b180a6a7d1d24d39b3db55f4064f12a8c7 and its currently misclassified schema dependency installed for diagnostics. All nine CLI scene steps passed (cli-prepare-before-stop-20260926); build and file policies pass. SDK #335 corrects the dependency classification upstream and must integrate before consumer Actions are judged. No live golden pass claimed.
Risk and rollback
Only caller-owned preparation runs before stop. Manager-owned build custody remains unchanged. Revert exact commits if required; generated files reflect SDK authority.
Completion summary
Local regression complete; merge after required checks. The encrypted provider disk safety gate remains blocked; do not lower the threshold or remove active candidate evidence.