Skip to content

chore: add testbox workflows and scripts#4071

Merged
carderne merged 4 commits into
mainfrom
chore/blacksmith-testbox
Jun 29, 2026
Merged

chore: add testbox workflows and scripts#4071
carderne merged 4 commits into
mainfrom
chore/blacksmith-testbox

Conversation

@carderne

Copy link
Copy Markdown
Contributor

Needed to trigger Blacksmith Testbox workflows.

@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e64a491

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 10ee2852-b7e4-41cd-871e-972e798d3fa6

📥 Commits

Reviewing files that changed from the base of the PR and between 45d13cf and e64a491.

📒 Files selected for processing (2)
  • .github/workflows/pr-testbox.yml
  • scripts/test-pr-check.sh
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/pr-testbox.yml
  • scripts/test-pr-check.sh
📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: Analyze (javascript-typescript)

Walkthrough

Two GitHub Actions workflows were added for Blacksmith Testbox CI, one for Linux and one for Windows. Both are manually triggered with a required testbox_id input and include Testbox start and end steps. Two PR check scripts were added for Linux and Windows, covering installs, builds, Prisma generation, and test execution. A documentation file was also added describing how to run and stop the Testbox workflows.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too brief and omits required template sections like issue link, checklist, testing, changelog, and screenshots. Fill in Closes #, complete the checklist, add testing steps, summarize the changes in Changelog, and include screenshots if relevant.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change set: adding Blacksmith Testbox workflows and scripts.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/blacksmith-testbox

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

github-advanced-security[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@carderne carderne marked this pull request as ready for review June 29, 2026 12:57

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/pr-testbox.yml (1)

47-48: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

Use sudo for the /etc/docker directory creation.

Line 47 can fail with a permission error on runners where /etc/docker does not already exist, which makes the Docker reconfiguration path brittle before the daemon restart.

Suggested fix
-          mkdir -p /etc/docker
+          sudo mkdir -p /etc/docker
           echo "$CONFIG" | sudo tee /etc/docker/daemon.json

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1648f337-c0fd-4238-9d3a-602c92b7db0c

📥 Commits

Reviewing files that changed from the base of the PR and between 832f61a and 45d13cf.

📒 Files selected for processing (2)
  • .github/workflows/pr-testbox-windows.yml
  • .github/workflows/pr-testbox.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: typecheck / typecheck
🔇 Additional comments (2)
.github/workflows/pr-testbox.yml (1)

125-127: 🎯 Functional Correctness

run-testbox does not need a command here
useblacksmith/run-testbox is the Testbox handoff/idle monitor; it does not accept scripts/test-pr-check.sh as an input, so this step is fine as-is.

			> Likely an incorrect or invalid review comment.
.github/workflows/pr-testbox-windows.yml (1)

21-21: LGTM!

Also applies to: 57-57

devin-ai-integration[bot]

This comment was marked as resolved.

@carderne carderne enabled auto-merge (squash) June 29, 2026 13:20
@carderne carderne merged commit 243d52b into main Jun 29, 2026
42 checks passed
@carderne carderne deleted the chore/blacksmith-testbox branch June 29, 2026 14:08
@carderne carderne restored the chore/blacksmith-testbox branch June 29, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants