Feature/config manager push telemetry - #122
Conversation
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
You may want to wait until the ESV variables PR is in that adds the global flags you need to make the changes for this PR (since you will need them)
| /* | ||
| FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -c otlp -N datadog -e test-value -D test/e2e/exports/fr-config-manager/cloud | ||
| FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -D test/e2e/exports/fr-config-manager/cloud | ||
| */ |
There was a problem hiding this comment.
Add another test for importing using only the -c flag (no -n flag), and have it import the splunk configuration that you add in so we can also test importing splunk.
927a373 to
2c24ca1
Compare
| .filter((f) => !name || f === `${name}.json`); | ||
| for (const file of files) { | ||
| const filePath = `${catDir}/${file}`; | ||
| const provider = readJsonFile(filePath) as any; |
There was a problem hiding this comment.
I would change any to LogExporterSkeleton
|
Also, ensure that the config import and config export tests are passing, since I updated the library to include telemetry in the full export/import. You don't need to re-record those tests, you can just add the network calls to the mock recordings that are missing (the ones for telemetry) and then they should pass again (although you may need to still run update to update the snapshots). You can find those mock requests from the mock recordings for your config-manager push/pull test mocks. Let me know if you have questions on how to do this, but we don't want to re-record those because we don't want to break anything in the tenant |
2c24ca1 to
43d75b7
Compare
2 participants
No description provided.