Skip to content

ci: sync GitHub build images with CircleCI#134

Merged
CodeNinjaEvan merged 1 commit into
tronprotocol:release_0.8.31from
yanghang8612:ci/sync-release-0.8.31-build-images
Jul 16, 2026
Merged

ci: sync GitHub build images with CircleCI#134
CodeNinjaEvan merged 1 commit into
tronprotocol:release_0.8.31from
yanghang8612:ci/sync-release-0.8.31-build-images

Conversation

@yanghang8612

Copy link
Copy Markdown

Summary

  • align the GitHub Actions Linux build image with CircleCI's ubuntu2404-6 image
  • align the GitHub Actions Emscripten build image with CircleCI's emscripten-21 image
  • keep both images pinned to the same digests used by .circleci/config.yml

Root cause

PR #133 raised the minimum Boost version to 1.83 and updated the CircleCI and Emscripten script images, but .github/workflows/build.yml still used the older images. The Emscripten job therefore ran with Boost 1.75 and failed during CMake configuration.

Failed build: https://github.com/tronprotocol/solidity/actions/runs/29410477729/job/87336095268

Impact

The Emscripten build can use the required Boost 1.83 toolchain, and the GitHub Actions Linux/Emscripten environments no longer drift from CircleCI.

Validation

  • parsed .github/workflows/build.yml successfully as YAML
  • ran git diff --check
  • verified both pinned GHCR image manifests resolve successfully
  • confirmed the image names and digests exactly match .circleci/config.yml

actionlint was not available locally.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@yanghang8612
yanghang8612 marked this pull request as ready for review July 16, 2026 02:58
@CodeNinjaEvan
CodeNinjaEvan merged commit 74aae17 into tronprotocol:release_0.8.31 Jul 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants