Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Enter on a message always started a reply, ignoring the configured double-click action. This addresses the first follow-up in #57.
Return and keypad Enter now share the same action dispatcher as double-click: Reply, either reaction, Show Contact Details, Show Message Menu, or Do Nothing. Keyboard menus are anchored to the focused message. Only Reply moves focus to the composer, so reactions and Do Nothing preserve keyboard navigation.
Settings, shortcut help, the README and the accessibility checklist describe the behavior. Modified Enter, embedded controls, selection mode and unaccepted contact requests retain their existing handling.
Validation:
a11y=trueanda11y=false(webxdc=falselocally).git diff --checkpasses.Based directly on main. This PR addresses the Enter-action item and leaves the broader #57 open.