Skip to content

ci(device-agent): gate signing jobs by branch and environment #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tofikwest merged 1 commit into from
Oct 7, 2026
Merged

ci(device-agent): gate signing jobs by branch and environment #3584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/device-agent-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
name: Device Agent Release

# The push trigger is intentionally limited to protected branches (main, release).
# This pipeline handles Apple code-signing secrets (MAC_CSC_LINK, APPLE_ID, ...) and
# SSL.com eSigner secrets (ESIGNER_*) - broadening it to arbitrary branches would let
# anyone who can push a branch exfiltrate those credentials. Manual staging builds are
# still available via workflow_dispatch.
# Signed builds run only for main (staging) and release (production), inside the
# matching GitHub environment. The environment deployment-branch policy enforces
# this independently of the workflow file, so a build dispatched from, or pushed
# on, any other branch is rejected rather than signed.
on:
workflow_dispatch:
push:
Expand Down Expand Up @@ -94,6 +93,7 @@ jobs:
build-macos:
name: Build macOS (.dmg + .zip)
needs: detect-version
if: github.ref_name == 'main' || github.ref_name == 'release'
runs-on: macos-latest
environment: ${{ needs.detect-version.outputs.s3_env }}
defaults:
Expand Down Expand Up @@ -153,6 +153,7 @@ jobs:
build-windows:
name: Build Windows (.exe)
needs: detect-version
if: github.ref_name == 'main' || github.ref_name == 'release'
runs-on: windows-latest
environment: ${{ needs.detect-version.outputs.s3_env }}
defaults:
Expand Down Expand Up @@ -302,6 +303,7 @@ jobs:
build-linux:
name: Build Linux (.AppImage, .deb)
needs: detect-version
if: github.ref_name == 'main' || github.ref_name == 'release'
runs-on: ubuntu-latest
defaults:
run:
Expand Down