Skip to content

reproduce missing schematic section dividers for small gaps - #3640

Closed
mohan-bee wants to merge 1 commit into
tscircuit:mainfrom
mohan-bee:repro/schematic-section-small-gap-dividers
Closed

reproduce missing schematic section dividers for small gaps#3640
mohan-bee wants to merge 1 commit into
tscircuit:mainfrom
mohan-bee:repro/schematic-section-small-gap-dividers

Conversation

@mohan-bee

@mohan-bee mohan-bee commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

motivation
the real kicad benchmark board declares four schematic sections, but the divider calculation treats their distinct component bounds as overlapping.

before
the real board emits zero schematic divider lines, leaving its four intended regions visually unpartitioned in the schematic svg.

after
a focused 23-line regression records the zero-divider failure with numeric assertions and the complete real board schematic svg.

@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Sep 4, 2026 9:05am UTC

Request Review

@mohan-bee

Copy link
Copy Markdown
Contributor Author

migrated to direct branch pr #3642

@mohan-bee mohan-bee closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant