use library cell margins to preserve schematic section dividers - #3646
Merged
mohan-bee merged 4 commits intoSep 5, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
reviewed
Sep 4, 2026
seveibar
reviewed
Sep 4, 2026
seveibar
left a comment
seveibar
left a comment
Contributor
There was a problem hiding this comment.
doesn't this fix belong in caclulateCellBoundaries? we don't want algorithm code in core generally
mohan-bee
changed the title
mohan-bee
marked this pull request as draft
September 4, 2026 21:42
mohan-bee
marked this pull request as ready for review
September 5, 2026 04:15
mohan-bee
force-pushed
the
fix/schematic-section-small-gap-dividers
branch
from
September 5, 2026 04:17
29d7662 to
b43a4bc
Compare
imrishabh18
approved these changes
Sep 5, 2026
mohan-bee
force-pushed
the
fix/schematic-section-small-gap-dividers
branch
from
September 5, 2026 14:20
b43a4bc to
006c4cc
Compare
mohan-bee
force-pushed
the
fix/schematic-section-small-gap-dividers
branch
from
September 5, 2026 18:11
006c4cc to
1d7805a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation
compact schematic sections lose their dividers when core expands their bounds before boundary calculation.
before
the real benchmark's four expanded sections produce zero dividers in the reproduction snapshot.
after
core uses the published calculate-cell-boundaries 0.0.21 release and passes raw section bounds with a one millimeter preferred margin. the library owns margin handling. the real-board snapshot shows three dividers forming four sections, and the three protected section snapshots remain unchanged.