feat: support explicit pinrow courtyard dimensions - #860
Open
rushabhcodes wants to merge 1 commit into
Open
rushabhcodes wants to merge 1 commit into
rushabhcodes wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The SparkFun RFM69 breakout work in tscircuit/sparkfun-boards#325 exposed a valid layout that the generated pinrow courtyard cannot currently represent. The board uses separate 5-pin and 3-pin header components placed end-to-end as a contiguous breakaway header. Their physical bodies touch, but each generated courtyard includes the standard clearance, so the two courtyards overlap.
The existing default should not be reduced globally: comparisons with equivalent KiCad 2.54 mm vertical pin-header footprints show that footprinter's calculated courtyard is already slightly smaller and intentionally preserves normal component-clearance behavior. A relative margin modifier would also be ambiguous because its reference geometry would need to be defined.
Exact courtyard width and height are unambiguous and already follow the cyw/cyh convention used by smdpads and custom passive footprints. Extending that convention to pinrow allows exceptional mechanical layouts to specify their actual courtyard without changing every existing pinrow footprint.
Example:
What changed
Compatibility
This is opt-in. Existing footprint strings generate the same courtyard as before.
Testing